Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1750143003: Remove ephelper and other endpoints code. (Closed)

Created:
4 years, 9 months ago by dnj
Modified:
4 years, 9 months ago
Reviewers:
Vadim Sh., iannucci
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Remove ephelper and other endpoints code. BUG= Committed: https://github.com/luci/luci-go/commit/19a8eddcb133b81126ebea69f032df966a937c28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4441 lines) Patch
D appengine/apigen_examples/README.md View 1 chunk +0 lines, -16 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/README.md View 1 chunk +0 lines, -18 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/api/dumb_counter/v1/dumb_counter-api.json View 1 chunk +0 lines, -218 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/api/dumb_counter/v1/dumb_counter-gen.go View 1 chunk +0 lines, -630 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/apitest/main.go View 1 chunk +0 lines, -96 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/dumbCounter/model.go View 1 chunk +0 lines, -14 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/dumbCounter/service.go View 1 chunk +0 lines, -32 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/dumbCounter/service_add.go View 1 chunk +0 lines, -56 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/dumbCounter/service_cas.go View 1 chunk +0 lines, -52 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/dumbCounter/service_currentvalue.go View 1 chunk +0 lines, -44 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/dumbCounter/service_list.go View 1 chunk +0 lines, -36 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/service/app.yaml View 1 chunk +0 lines, -16 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/service/gen.go View 1 chunk +0 lines, -7 lines 0 comments Download
D appengine/apigen_examples/dumb_counter/service/main.go View 1 chunk +0 lines, -20 lines 0 comments Download
D appengine/apigen_examples/dumb_counter_mvm/README.md View 1 chunk +0 lines, -15 lines 0 comments Download
D appengine/apigen_examples/dumb_counter_mvm/api/dumb_counter/v1/dumb_counter-api.json View 1 chunk +0 lines, -170 lines 0 comments Download
D appengine/apigen_examples/dumb_counter_mvm/api/dumb_counter/v1/dumb_counter-gen.go View 1 chunk +0 lines, -633 lines 0 comments Download
D appengine/apigen_examples/dumb_counter_mvm/service/app.yaml View 1 chunk +0 lines, -17 lines 0 comments Download
D appengine/apigen_examples/dumb_counter_mvm/service/gen.go View 1 chunk +0 lines, -7 lines 0 comments Download
D appengine/apigen_examples/dumb_counter_mvm/service/main.go View 1 chunk +0 lines, -25 lines 0 comments Download
D appengine/ephelper/assertions/errors.go View 1 chunk +0 lines, -155 lines 0 comments Download
D appengine/ephelper/context.go View 1 chunk +0 lines, -80 lines 0 comments Download
D appengine/ephelper/epfrontend/discovery.go View 1 chunk +0 lines, -307 lines 0 comments Download
D appengine/ephelper/epfrontend/discovery_test.go View 1 chunk +0 lines, -61 lines 0 comments Download
D appengine/ephelper/epfrontend/discovery_testdata/basic_backend.json View 1 chunk +0 lines, -49 lines 0 comments Download
D appengine/ephelper/epfrontend/discovery_testdata/basic_frontend.json View 1 chunk +0 lines, -47 lines 0 comments Download
D appengine/ephelper/epfrontend/discovery_testdata/query_get_backend.json View 1 chunk +0 lines, -48 lines 0 comments Download
D appengine/ephelper/epfrontend/discovery_testdata/query_get_frontend.json View 1 chunk +0 lines, -44 lines 0 comments Download
D appengine/ephelper/epfrontend/doc.go View 1 chunk +0 lines, -13 lines 0 comments Download
D appengine/ephelper/epfrontend/error.go View 1 chunk +0 lines, -184 lines 0 comments Download
D appengine/ephelper/epfrontend/error_test.go View 1 chunk +0 lines, -162 lines 0 comments Download
D appengine/ephelper/epfrontend/json.go View 1 chunk +0 lines, -31 lines 0 comments Download
D appengine/ephelper/epfrontend/service.go View 1 chunk +0 lines, -490 lines 0 comments Download
D appengine/ephelper/epfrontend/service_test.go View 1 chunk +0 lines, -300 lines 0 comments Download
D appengine/ephelper/epfrontend/service_testdata/test_directory.json View 1 chunk +0 lines, -16 lines 0 comments Download
D appengine/ephelper/epfrontend/service_testdata/test_service.json View 1 chunk +0 lines, -117 lines 0 comments Download
D appengine/ephelper/epfrontend/util.go View 1 chunk +0 lines, -16 lines 0 comments Download
D appengine/ephelper/epfrontend/util_test.go View 1 chunk +0 lines, -30 lines 0 comments Download
D appengine/ephelper/ephelper.go View 1 chunk +0 lines, -102 lines 0 comments Download
D appengine/ephelper/errors.go View 1 chunk +0 lines, -25 lines 0 comments Download
D appengine/ephelper/middleware.go View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dnj
PTAL
4 years, 9 months ago (2016-03-01 22:09:49 UTC) #2
Vadim Sh.
lgtm, but make sure infra & infra_internal builds without this stuff first (it should..)
4 years, 9 months ago (2016-03-01 22:16:54 UTC) #3
iannucci
lgtm
4 years, 9 months ago (2016-03-01 22:36:44 UTC) #4
dnj
I don't see any references anymore at HEAD, so I think we're set.
4 years, 9 months ago (2016-03-02 00:58:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750143003/1
4 years, 9 months ago (2016-03-02 00:58:48 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 01:01:57 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/19a8eddcb133b81126ebea69f032df966a937c28

Powered by Google App Engine
This is Rietveld 408576698