Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issue 1750143002: Changes ownership of WindowTreeHostConnection (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes ownership of WindowTreeHostConnection Changes ownership of WindowTreeHostConnection Previously WindowTreeHostConnection owned then WindowTreeHost. This change makes the WindowTreeHosts owned by the ConnectionManager. WindowTreeHost in turn owns the WindowTreeHostConnection. I'm doing this as multiple windows managers per display implies WindowTreeHost won't always have a WindowTreeHostConnection. I also nuked WindowTreeHostDelegate and folded into WindowTreeHostConnection. BUG=590955 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba Cr-Commit-Position: refs/heads/master@{#378393}

Patch Set 1 #

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -245 lines) Patch
M components/mus/mus_app.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/connection_manager.h View 1 5 chunks +14 lines, -10 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 1 10 chunks +62 lines, -45 lines 0 comments Download
M components/mus/ws/window_tree_host_connection.h View 1 3 chunks +14 lines, -45 lines 0 comments Download
M components/mus/ws/window_tree_host_connection.cc View 1 chunk +8 lines, -48 lines 0 comments Download
D components/mus/ws/window_tree_host_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 1 4 chunks +7 lines, -3 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 8 chunks +22 lines, -19 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 9 chunks +24 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sky
4 years, 9 months ago (2016-03-01 03:33:11 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-01 03:48:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750143002/20001
4 years, 9 months ago (2016-03-01 03:52:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 04:16:30 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 04:18:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04ce21af244667b86ba7fa17f99e0d45f7d577ba
Cr-Commit-Position: refs/heads/master@{#378393}

Powered by Google App Engine
This is Rietveld 408576698