Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 175013: If a preferences file references a theme which is from an old version, or who... (Closed)

Created:
11 years, 3 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
tony, glen
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

If a preferences file references a theme which is from an old version, or whose images have failed to process correctly, drop back to the default theme. BUG= http://crbug.com/20263 TEST= Use a preferences file from an older version of Chrome that has a theme installed, and open Chrome. Observe that Chrome opens using the default theme. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24830

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/browser_theme_provider.cc View 1 2 3 4 5 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Miranda Callahan
This forces anybody with an old non-cached-style theme to get on the cached-theme train. I ...
11 years, 3 months ago (2009-08-28 21:45:15 UTC) #1
tony
LGTM. If you wanted, you could add a UMA metric for how often this code ...
11 years, 3 months ago (2009-08-28 21:50:56 UTC) #2
Miranda Callahan
11 years, 3 months ago (2009-08-28 22:05:15 UTC) #3
Oh, very interesting, that's a great idea -- thanks, I'll do that!

Powered by Google App Engine
This is Rietveld 408576698