Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/renderer/net/net_error_helper.h

Issue 1750113002: Remove "Show saved copy" button from error page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/net/net_error_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/net/net_error_helper.h
diff --git a/chrome/renderer/net/net_error_helper.h b/chrome/renderer/net/net_error_helper.h
index 80f1a9ef85fec87aa0ae8aaaf7217464d3ef681b..66b9ff89b761c44e8586e8fc7113a434b873f213 100644
--- a/chrome/renderer/net/net_error_helper.h
+++ b/chrome/renderer/net/net_error_helper.h
@@ -13,7 +13,6 @@
#include "build/build_config.h"
#include "chrome/renderer/net/net_error_page_controller.h"
#include "components/error_page/common/net_error_info.h"
-#include "components/error_page/common/offline_page_types.h"
#include "components/error_page/renderer/net_error_helper_core.h"
#include "content/public/renderer/render_frame_observer.h"
#include "content/public/renderer/render_frame_observer_tracker.h"
@@ -87,21 +86,19 @@ class NetErrorHelper
const blink::WebURLError& error,
bool is_failed_post,
bool can_use_local_diagnostics_service,
- error_page::OfflinePageStatus offline_page_status,
+ bool has_offline_pages,
scoped_ptr<error_page::ErrorPageParams> params,
bool* reload_button_shown,
bool* show_saved_copy_button_shown,
bool* show_cached_copy_button_shown,
bool* show_offline_pages_button_shown,
- bool* show_offline_copy_button_shown,
std::string* html) const override;
void LoadErrorPage(const std::string& html, const GURL& failed_url) override;
void EnablePageHelperFunctions() override;
- void UpdateErrorPage(
- const blink::WebURLError& error,
- bool is_failed_post,
- bool can_use_local_diagnostics_service,
- error_page::OfflinePageStatus offline_page_status) override;
+ void UpdateErrorPage(const blink::WebURLError& error,
+ bool is_failed_post,
+ bool can_use_local_diagnostics_service,
+ bool has_offline_pages) override;
void FetchNavigationCorrections(
const GURL& navigation_correction_url,
const std::string& navigation_correction_request_body) override;
@@ -112,7 +109,6 @@ class NetErrorHelper
void LoadPageFromCache(const GURL& page_url) override;
void DiagnoseError(const GURL& page_url) override;
void ShowOfflinePages() override;
- void LoadOfflineCopy(const GURL& page_url) override;
void OnNetErrorInfo(int status);
void OnSetCanShowNetworkDiagnosticsDialog(
@@ -130,9 +126,9 @@ class NetErrorHelper
const std::string& data);
#if defined(OS_ANDROID)
- // Called to set the status of the offline pages that will be used to decide
+ // Called to set whether offline pages exists, which will be used to decide
// if offline related button will be provided in the error page.
- void OnSetOfflinePageInfo(error_page::OfflinePageStatus offline_page_status);
+ void OnSetHasOfflinePages(bool has_offline_pages);
#endif
scoped_ptr<content::ResourceFetcher> correction_fetcher_;
« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/net/net_error_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698