Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 1750113002: Remove "Show saved copy" button from error page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | components/error_page.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/net/net_error_page_controller.h" 5 #include "chrome/renderer/net/net_error_page_controller.h"
6 6
7 #include "base/strings/string_piece.h" 7 #include "base/strings/string_piece.h"
8 #include "content/public/renderer/render_frame.h" 8 #include "content/public/renderer/render_frame.h"
9 #include "gin/handle.h" 9 #include "gin/handle.h"
10 #include "gin/object_template_builder.h" 10 #include "gin/object_template_builder.h"
(...skipping 29 matching lines...) Expand all
40 } 40 }
41 41
42 bool NetErrorPageController::ShowSavedCopyButtonClick() { 42 bool NetErrorPageController::ShowSavedCopyButtonClick() {
43 return ButtonClick(error_page::NetErrorHelperCore::SHOW_SAVED_COPY_BUTTON); 43 return ButtonClick(error_page::NetErrorHelperCore::SHOW_SAVED_COPY_BUTTON);
44 } 44 }
45 45
46 bool NetErrorPageController::ShowOfflinePagesButtonClick() { 46 bool NetErrorPageController::ShowOfflinePagesButtonClick() {
47 return ButtonClick(error_page::NetErrorHelperCore::SHOW_OFFLINE_PAGES_BUTTON); 47 return ButtonClick(error_page::NetErrorHelperCore::SHOW_OFFLINE_PAGES_BUTTON);
48 } 48 }
49 49
50 bool NetErrorPageController::ShowOfflineCopyButtonClick() {
51 return ButtonClick(error_page::NetErrorHelperCore::SHOW_OFFLINE_COPY_BUTTON);
52 }
53
54 bool NetErrorPageController::ReloadButtonClick() { 50 bool NetErrorPageController::ReloadButtonClick() {
55 return ButtonClick(error_page::NetErrorHelperCore::RELOAD_BUTTON); 51 return ButtonClick(error_page::NetErrorHelperCore::RELOAD_BUTTON);
56 } 52 }
57 53
58 bool NetErrorPageController::DetailsButtonClick() { 54 bool NetErrorPageController::DetailsButtonClick() {
59 return ButtonClick(error_page::NetErrorHelperCore::MORE_BUTTON); 55 return ButtonClick(error_page::NetErrorHelperCore::MORE_BUTTON);
60 } 56 }
61 57
62 bool NetErrorPageController::TrackEasterEgg() { 58 bool NetErrorPageController::TrackEasterEgg() {
63 return ButtonClick(error_page::NetErrorHelperCore::EASTER_EGG); 59 return ButtonClick(error_page::NetErrorHelperCore::EASTER_EGG);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 NetErrorPageController::~NetErrorPageController() {} 91 NetErrorPageController::~NetErrorPageController() {}
96 92
97 gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder( 93 gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(
98 v8::Isolate* isolate) { 94 v8::Isolate* isolate) {
99 return gin::Wrappable<NetErrorPageController>::GetObjectTemplateBuilder( 95 return gin::Wrappable<NetErrorPageController>::GetObjectTemplateBuilder(
100 isolate) 96 isolate)
101 .SetMethod("showSavedCopyButtonClick", 97 .SetMethod("showSavedCopyButtonClick",
102 &NetErrorPageController::ShowSavedCopyButtonClick) 98 &NetErrorPageController::ShowSavedCopyButtonClick)
103 .SetMethod("showOfflinePagesButtonClick", 99 .SetMethod("showOfflinePagesButtonClick",
104 &NetErrorPageController::ShowOfflinePagesButtonClick) 100 &NetErrorPageController::ShowOfflinePagesButtonClick)
105 .SetMethod("showOfflineCopyButtonClick",
106 &NetErrorPageController::ShowOfflineCopyButtonClick)
107 .SetMethod("reloadButtonClick", 101 .SetMethod("reloadButtonClick",
108 &NetErrorPageController::ReloadButtonClick) 102 &NetErrorPageController::ReloadButtonClick)
109 .SetMethod("detailsButtonClick", 103 .SetMethod("detailsButtonClick",
110 &NetErrorPageController::DetailsButtonClick) 104 &NetErrorPageController::DetailsButtonClick)
111 .SetMethod("diagnoseErrorsButtonClick", 105 .SetMethod("diagnoseErrorsButtonClick",
112 &NetErrorPageController::DiagnoseErrorsButtonClick) 106 &NetErrorPageController::DiagnoseErrorsButtonClick)
113 .SetMethod("trackClick", &NetErrorPageController::TrackClick) 107 .SetMethod("trackClick", &NetErrorPageController::TrackClick)
114 .SetMethod("trackEasterEgg", &NetErrorPageController::TrackEasterEgg) 108 .SetMethod("trackEasterEgg", &NetErrorPageController::TrackEasterEgg)
115 .SetMethod("trackCachedCopyButtonClick", 109 .SetMethod("trackCachedCopyButtonClick",
116 &NetErrorPageController::TrackCachedCopyButtonClick); 110 &NetErrorPageController::TrackCachedCopyButtonClick);
117 } 111 }
OLDNEW
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | components/error_page.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698