Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chrome/browser/ui/browser_command_controller.cc

Issue 17501006: Remove "View Background Pages". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gtk Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_command_controller.h" 5 #include "chrome/browser/ui/browser_command_controller.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/defaults.h" 10 #include "chrome/browser/defaults.h"
(...skipping 609 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 case IDC_DEV_TOOLS_CONSOLE: 620 case IDC_DEV_TOOLS_CONSOLE:
621 ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE); 621 ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);
622 break; 622 break;
623 case IDC_DEV_TOOLS_INSPECT: 623 case IDC_DEV_TOOLS_INSPECT:
624 ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_INSPECT); 624 ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_INSPECT);
625 break; 625 break;
626 case IDC_DEV_TOOLS_TOGGLE: 626 case IDC_DEV_TOOLS_TOGGLE:
627 ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_TOGGLE); 627 ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_TOGGLE);
628 break; 628 break;
629 case IDC_TASK_MANAGER: 629 case IDC_TASK_MANAGER:
630 OpenTaskManager(browser_, false); 630 OpenTaskManager(browser_);
631 break;
632 case IDC_VIEW_BACKGROUND_PAGES:
633 OpenTaskManager(browser_, true);
634 break; 631 break;
635 case IDC_FEEDBACK: 632 case IDC_FEEDBACK:
636 OpenFeedbackDialog(browser_); 633 OpenFeedbackDialog(browser_);
637 break; 634 break;
638 635
639 case IDC_SHOW_BOOKMARK_BAR: 636 case IDC_SHOW_BOOKMARK_BAR:
640 ToggleBookmarkBar(browser_); 637 ToggleBookmarkBar(browser_);
641 break; 638 break;
642 case IDC_PROFILING_ENABLED: 639 case IDC_PROFILING_ENABLED:
643 Profiling::Toggle(); 640 Profiling::Toggle();
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
934 931
935 // Show various bits of UI 932 // Show various bits of UI
936 command_updater_.UpdateCommandEnabled(IDC_CLEAR_BROWSING_DATA, normal_window); 933 command_updater_.UpdateCommandEnabled(IDC_CLEAR_BROWSING_DATA, normal_window);
937 934
938 // The upgrade entry and the view incompatibility entry should always be 935 // The upgrade entry and the view incompatibility entry should always be
939 // enabled. Whether they are visible is a separate matter determined on menu 936 // enabled. Whether they are visible is a separate matter determined on menu
940 // show. 937 // show.
941 command_updater_.UpdateCommandEnabled(IDC_UPGRADE_DIALOG, true); 938 command_updater_.UpdateCommandEnabled(IDC_UPGRADE_DIALOG, true);
942 command_updater_.UpdateCommandEnabled(IDC_VIEW_INCOMPATIBILITIES, true); 939 command_updater_.UpdateCommandEnabled(IDC_VIEW_INCOMPATIBILITIES, true);
943 940
944 // View Background Pages entry is always enabled, but is hidden if there are
945 // no background pages.
946 command_updater_.UpdateCommandEnabled(IDC_VIEW_BACKGROUND_PAGES, true);
947
948 // Toggle speech input 941 // Toggle speech input
949 command_updater_.UpdateCommandEnabled(IDC_TOGGLE_SPEECH_INPUT, true); 942 command_updater_.UpdateCommandEnabled(IDC_TOGGLE_SPEECH_INPUT, true);
950 943
951 // Initialize other commands whose state changes based on fullscreen mode. 944 // Initialize other commands whose state changes based on fullscreen mode.
952 UpdateCommandsForFullscreenMode(FULLSCREEN_DISABLED); 945 UpdateCommandsForFullscreenMode(FULLSCREEN_DISABLED);
953 946
954 UpdateCommandsForContentRestrictionState(); 947 UpdateCommandsForContentRestrictionState();
955 948
956 UpdateCommandsForBookmarkEditing(); 949 UpdateCommandsForBookmarkEditing();
957 950
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
1251 1244
1252 BrowserWindow* BrowserCommandController::window() { 1245 BrowserWindow* BrowserCommandController::window() {
1253 return browser_->window(); 1246 return browser_->window();
1254 } 1247 }
1255 1248
1256 Profile* BrowserCommandController::profile() { 1249 Profile* BrowserCommandController::profile() {
1257 return browser_->profile(); 1250 return browser_->profile();
1258 } 1251 }
1259 1252
1260 } // namespace chrome 1253 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698