Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17501006: Remove "View Background Pages". (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, sadrul, ben+watch_chromium.org, tburkard+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove "View Background Pages". BUG=148581 TEST=No more "feature". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208061

Patch Set 1 #

Patch Set 2 : gtk #

Total comments: 2

Patch Set 3 : cleaner #

Total comments: 2

Patch Set 4 : fixes #

Patch Set 5 : real gtk fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -394 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/processes/processes_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/task_manager/main.js View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/task_manager/task_manager.css View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 5 chunks +1 line, -101 lines 0 comments Download
M chrome/browser/task_manager/task_manager_notification_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.h View 6 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 3 5 chunks +11 lines, -68 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.h View 1 2 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 1 2 3 4 9 chunks +7 lines, -30 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 5 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 13 chunks +11 lines, -63 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/event_pages.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Avi (use Gerrit)
Robert: Mac code Elliot: GTK code Scott: Views code + everything else
7 years, 6 months ago (2013-06-20 23:20:13 UTC) #1
sky
LGTM
7 years, 6 months ago (2013-06-20 23:56:02 UTC) #2
Elliot Glaysher
gtk lgtm
7 years, 6 months ago (2013-06-21 00:35:22 UTC) #3
Avi (use Gerrit)
Robert is OOO; Nico, can you cover the Mac stuff?
7 years, 6 months ago (2013-06-21 15:24:31 UTC) #4
Mark Mentovai
LGTM for Mac review. I also looked over the rest of the change. Thanks for ...
7 years, 6 months ago (2013-06-21 15:39:21 UTC) #5
Avi (use Gerrit)
On 2013/06/21 15:39:21, Mark Mentovai wrote: > LGTM for Mac review. I also looked over ...
7 years, 6 months ago (2013-06-21 15:50:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/13001
7 years, 6 months ago (2013-06-21 15:51:41 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=142249
7 years, 6 months ago (2013-06-21 16:48:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/13001
7 years, 6 months ago (2013-06-21 16:50:04 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=142304
7 years, 6 months ago (2013-06-21 18:36:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/13001
7 years, 6 months ago (2013-06-21 18:39:55 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=142353
7 years, 6 months ago (2013-06-21 19:45:48 UTC) #12
Elliot Glaysher
https://codereview.chromium.org/17501006/diff/13001/chrome/browser/ui/gtk/task_manager_gtk.cc File chrome/browser/ui/gtk/task_manager_gtk.cc (left): https://codereview.chromium.org/17501006/diff/13001/chrome/browser/ui/gtk/task_manager_gtk.cc#oldcode220 chrome/browser/ui/gtk/task_manager_gtk.cc:220: "text", colid, Maybe this is what went wrong? Is ...
7 years, 6 months ago (2013-06-21 20:51:49 UTC) #13
Avi (use Gerrit)
https://codereview.chromium.org/17501006/diff/13001/chrome/browser/ui/gtk/task_manager_gtk.cc File chrome/browser/ui/gtk/task_manager_gtk.cc (left): https://codereview.chromium.org/17501006/diff/13001/chrome/browser/ui/gtk/task_manager_gtk.cc#oldcode220 chrome/browser/ui/gtk/task_manager_gtk.cc:220: "text", colid, On 2013/06/21 20:51:49, Elliot Glaysher wrote: > ...
7 years, 6 months ago (2013-06-21 20:57:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/16004
7 years, 6 months ago (2013-06-21 21:40:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/16004
7 years, 6 months ago (2013-06-22 02:44:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/16004
7 years, 6 months ago (2013-06-22 03:08:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/16004
7 years, 6 months ago (2013-06-22 03:20:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/16004
7 years, 6 months ago (2013-06-22 03:35:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17501006/16004
7 years, 6 months ago (2013-06-22 03:43:19 UTC) #20
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 15:39:40 UTC) #21
Message was sent while issue was closed. 
Change committed as 208061

Powered by Google App Engine
This is Rietveld 408576698