runtime/vm/flow_graph_optimizer.cc - Issue 17501003: Minor cleanups to use null_array(), null_object() and null_string() handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 17501003: Minor cleanups to use null_array(), null_object() and null_string() handles. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 24241)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -2111,7 +2111,7 @@

case kTypedDataUint16ArrayCid: {

// Check that value is always smi.

value_check = ICData::New(Function::Handle(),

- String::Handle(),

+ Object::null_string(),

Object::null_array(),

Isolate::kNoDeoptId,

1);

@@ -2125,7 +2125,7 @@

// before storing to handle the mint case, too.

if (call->ic_data()->deopt_reason() == kDeoptUnknown) {

value_check = ICData::New(Function::Handle(),

- String::Handle(),

+ Object::null_string(),

Object::null_array(), // Dummy args. descr.

Isolate::kNoDeoptId,

1);

@@ -2136,7 +2136,7 @@

case kTypedDataFloat64ArrayCid: {

// Check that value is always double.

value_check = ICData::New(Function::Handle(),

- String::Handle(),

+ Object::null_string(),

Object::null_array(), // Dummy args. descr.

Isolate::kNoDeoptId,

1);

@@ -2146,7 +2146,7 @@

case kTypedDataFloat32x4ArrayCid: {

// Check that value is always Float32x4.

value_check = ICData::New(Function::Handle(),

- String::Handle(),

+ Object::null_string(),

Object::null_array(), // Dummy args. descr.

Isolate::kNoDeoptId,

1);

« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »