Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

Issue 1750083004: Add badge to web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/NotificationData.cpp
diff --git a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp
index e26722f3c95ad6101c87623c5885e12cf251117f..ed67c9e3882698816287013ef69bab0c2bbc438d 100644
--- a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp
+++ b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp
@@ -11,7 +11,7 @@
#include "modules/notifications/Notification.h"
#include "modules/notifications/NotificationOptions.h"
#include "modules/vibration/NavigatorVibration.h"
-#include "platform/weborigin/KURL.h"
+#include "public/platform/WebURL.h"
#include "wtf/CurrentTime.h"
namespace blink {
@@ -27,6 +27,14 @@ WebNotificationData::Direction toDirectionEnumValue(const String& direction)
return WebNotificationData::DirectionAuto;
}
+WebURL completeURL(ExecutionContext* executionContext, const String& stringUrl)
+{
+ WebURL url = executionContext->completeURL(stringUrl);
+ if (url.isValid())
+ return url;
+ return WebURL();
+}
+
} // namespace
WebNotificationData createWebNotificationData(ExecutionContext* executionContext, const String& title, const NotificationOptions& options, ExceptionState& exceptionState)
@@ -51,15 +59,12 @@ WebNotificationData createWebNotificationData(ExecutionContext* executionContext
webData.body = options.body();
webData.tag = options.tag();
- KURL iconUrl;
+ if (options.hasIcon() && !options.icon().isEmpty())
+ webData.icon = completeURL(executionContext, options.icon());
- if (options.hasIcon() && !options.icon().isEmpty()) {
- iconUrl = executionContext->completeURL(options.icon());
- if (!iconUrl.isValid())
- iconUrl = KURL();
- }
+ if (options.hasBadge() && !options.badge().isEmpty())
+ webData.badge = completeURL(executionContext, options.badge());
- webData.icon = iconUrl;
webData.vibrate = NavigatorVibration::sanitizeVibrationPattern(options.vibrate());
webData.timestamp = options.hasTimestamp() ? static_cast<double>(options.timestamp()) : WTF::currentTimeMS();
webData.renotify = options.renotify();
@@ -88,13 +93,8 @@ WebNotificationData createWebNotificationData(ExecutionContext* executionContext
webAction.action = action.action();
webAction.title = action.title();
- KURL iconUrl;
- if (action.hasIcon() && !action.icon().isEmpty()) {
- iconUrl = executionContext->completeURL(action.icon());
- if (!iconUrl.isValid())
- iconUrl = KURL();
- }
- webAction.icon = iconUrl;
+ if (action.hasIcon() && !action.icon().isEmpty())
+ webAction.icon = completeURL(executionContext, action.icon());
actions.append(webAction);
}

Powered by Google App Engine
This is Rietveld 408576698