content/child/notifications/notification_manager.cc - Issue 1750083004: Add badge to web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/notifications/notification_manager.cc

Issue 1750083004: Add badge to web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/notifications/notification_manager.cc

diff --git a/content/child/notifications/notification_manager.cc b/content/child/notifications/notification_manager.cc

index e1345d0e70e478ccc25f931d8df8b485168b9255..ae4c1ba442dc09685d60bb8f83db3e06dad7e07e 100644

--- a/content/child/notifications/notification_manager.cc

+++ b/content/child/notifications/notification_manager.cc

@@ -36,6 +36,8 @@ int CurrentWorkerId() {

bool HasResourcesToFetch(const blink::WebNotificationData& notification_data) {

if (!notification_data.icon.isEmpty())

return true;

+ if (!notification_data.badge.isEmpty())

+ return true;

for (const auto& action : notification_data.actions) {

if (!action.icon.isEmpty())

return true;