content/browser/notifications/notification_message_filter.cc - Issue 1750083004: Add badge to web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_message_filter.cc

Issue 1750083004: Add badge to web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/notifications/notification_message_filter.cc

diff --git a/content/browser/notifications/notification_message_filter.cc b/content/browser/notifications/notification_message_filter.cc

index f0a64a761e60099f2f21d385a08f31a4fa34a971..08297505482f79f8e6c3df5c906151f34736c66e 100644

--- a/content/browser/notifications/notification_message_filter.cc

+++ b/content/browser/notifications/notification_message_filter.cc

@@ -53,6 +53,10 @@ bool ValidateNotificationResources(const NotificationResources& resources) {

kPlatformNotificationMaxIconSizePx) {

return false;

}

+ if (resources.badge.width() > kPlatformNotificationMaxBadgeSizePx ||

+ resources.badge.height() > kPlatformNotificationMaxBadgeSizePx) {

+ return false;

+ }

for (const auto& action_icon : resources.action_icons) {

if (action_icon.width() > kPlatformNotificationMaxActionIconSizePx ||

action_icon.height() > kPlatformNotificationMaxActionIconSizePx) {