Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/browser/notifications/notification_ui_manager_android.cc

Issue 1750083004: Add badge to web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_ui_manager_android.cc
diff --git a/chrome/browser/notifications/notification_ui_manager_android.cc b/chrome/browser/notifications/notification_ui_manager_android.cc
index f1b8dc5e81f09821c763b6d0255c96227b52a9fd..d4b2f6f360dd683508045d5915d641e887dcb678 100644
--- a/chrome/browser/notifications/notification_ui_manager_android.cc
+++ b/chrome/browser/notifications/notification_ui_manager_android.cc
@@ -165,6 +165,11 @@ void NotificationUIManagerAndroid::Add(const Notification& notification,
if (!notification_icon_bitmap.drawsNothing())
notification_icon = gfx::ConvertToJavaBitmap(&notification_icon_bitmap);
+ ScopedJavaLocalRef<jobject> badge;
+ SkBitmap badge_bitmap = notification.small_image().AsBitmap();
+ if (!badge_bitmap.drawsNothing())
+ badge = gfx::ConvertToJavaBitmap(&badge_bitmap);
+
std::vector<base::string16> action_titles_vector;
for (const message_center::ButtonInfo& button : notification.buttons())
action_titles_vector.push_back(button.title);
@@ -183,7 +188,7 @@ void NotificationUIManagerAndroid::Add(const Notification& notification,
Java_NotificationUIManager_displayNotification(
env, java_object_.obj(), persistent_notification_id, origin.obj(),
profile_id.obj(), profile->IsOffTheRecord(), tag.obj(), title.obj(),
- body.obj(), notification_icon.obj(), vibration_pattern.obj(),
+ body.obj(), notification_icon.obj(), badge.obj(), vibration_pattern.obj(),
notification.timestamp().ToJavaTime(), notification.renotify(),
notification.silent(), action_titles.obj(), action_icons.obj());

Powered by Google App Engine
This is Rietveld 408576698