third_party/WebKit/Source/modules/notifications/NotificationOptions.idl - Issue 1750083004: Add badge to web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

Issue 1750083004: Add badge to web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/notifications/NotificationData.cpp ('K') | « third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl b/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

index 9b1ded4b9538fc82d59e566b404f7e542d279031..b3deebe1b09f7b97c6d720a2ed9173bbc8288b8f 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

@@ -16,6 +16,7 @@ dictionary NotificationOptions {

DOMString body = "";

DOMString tag = "";

USVString icon;

+ [RuntimeEnabled=NotificationExperimental] USVString smallIcon = "";

Peter Beverloo 2016/03/03 17:55:39 Why does this have a default value, but `icon` doe

Michael van Ouwerkerk 2016/03/09 18:28:25 Done.

// TODO(sh919.park): vibrate should be ([Clamp] unsigned long or sequence<unsigned long>)

(unsigned long or sequence<unsigned long>) vibrate;

DOMTimeStamp timestamp;