content/child/notifications/notification_data_conversions_unittest.cc - Issue 1750083004: Add badge to web notifications.

Unified Diff: content/child/notifications/notification_data_conversions_unittest.cc

Issue 1750083004: Add badge to web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « content/child/notifications/notification_data_conversions.cc ('k') | content/child/notifications/notification_manager.cc » ('j') | content/child/notifications/pending_notifications_tracker_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/notifications/notification_data_conversions_unittest.cc

diff --git a/content/child/notifications/notification_data_conversions_unittest.cc b/content/child/notifications/notification_data_conversions_unittest.cc

index 67b704e456b676e4fdaef1a7e3223f0d0d2a1ea3..522c4e90a1f300bd74749c89aa35e21a5e27279c 100644

--- a/content/child/notifications/notification_data_conversions_unittest.cc

+++ b/content/child/notifications/notification_data_conversions_unittest.cc

@@ -23,6 +23,7 @@ const char kNotificationLang[] = "nl";

const char kNotificationBody[] = "Hello, world!";

const char kNotificationTag[] = "my_tag";

const char kNotificationIconUrl[] = "https://example.com/icon.png";

+const char kNotificationSmallIconUrl[] = "https://example.com/small_icon.png";

const int kNotificationVibrationPattern[] = {100, 200, 300};

const double kNotificationTimestamp = 621046800.;

const unsigned char kNotificationData[] = {0xdf, 0xff, 0x0, 0x0, 0xff, 0xdf};

@@ -41,6 +42,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {

web_data.body = blink::WebString::fromUTF8(kNotificationBody);

web_data.tag = blink::WebString::fromUTF8(kNotificationTag);

web_data.icon = blink::WebURL(GURL(kNotificationIconUrl));

+ web_data.smallIcon = blink::WebURL(GURL(kNotificationSmallIconUrl));

web_data.vibrate = blink::WebVector<int>(

kNotificationVibrationPattern, arraysize(kNotificationVibrationPattern));

web_data.timestamp = kNotificationTimestamp;

@@ -67,6 +69,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {

EXPECT_EQ(base::ASCIIToUTF16(kNotificationBody), platform_data.body);

EXPECT_EQ(kNotificationTag, platform_data.tag);

EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());

+ EXPECT_EQ(kNotificationSmallIconUrl, platform_data.small_icon.spec());

EXPECT_TRUE(platform_data.renotify);

EXPECT_TRUE(platform_data.silent);

EXPECT_TRUE(platform_data.require_interaction);

@@ -102,6 +105,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {

platform_data.body = base::ASCIIToUTF16(kNotificationBody);

platform_data.tag = kNotificationTag;

platform_data.icon = GURL(kNotificationIconUrl);

+ platform_data.small_icon = GURL(kNotificationSmallIconUrl);

platform_data.vibration_pattern = vibration_pattern;

platform_data.timestamp = base::Time::FromJsTime(kNotificationTimestamp);

platform_data.renotify = true;

@@ -124,6 +128,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {

EXPECT_EQ(kNotificationBody, web_data.body);

EXPECT_EQ(kNotificationTag, web_data.tag);

EXPECT_EQ(kNotificationIconUrl, web_data.icon.string());

+ EXPECT_EQ(kNotificationSmallIconUrl, web_data.smallIcon.string());

ASSERT_EQ(vibration_pattern.size(), web_data.vibrate.size());

for (size_t i = 0; i < vibration_pattern.size(); ++i)