Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3109)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1750063002: Replicate static layout test configuration to all renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-test-finished-in-secondary-frames-please
Patch Set: Rebasing... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index 22648fe862f43acd3284fe379a5aadea8f4b4bb1..e6a06b3aead883f029447a1b224813e0900546d8 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -799,8 +799,6 @@ void BlinkTestRunner::DidClearWindowObject(WebLocalFrame* frame) {
bool BlinkTestRunner::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(BlinkTestRunner, message)
- IPC_MESSAGE_HANDLER(ShellViewMsg_SetTestConfiguration,
- OnSetTestConfiguration)
IPC_MESSAGE_HANDLER(ShellViewMsg_SessionHistory, OnSessionHistory)
IPC_MESSAGE_HANDLER(ShellViewMsg_Reset, OnReset)
IPC_MESSAGE_HANDLER(ShellViewMsg_NotifyDone, OnNotifyDone)
@@ -975,16 +973,11 @@ void BlinkTestRunner::CaptureDumpComplete() {
new ShellViewHostMsg_TestFinished(routing_id())));
}
-void BlinkTestRunner::OnSetTestConfiguration(
+void BlinkTestRunner::OnReplicateTestConfiguration(
const ShellTestConfiguration& params) {
test_config_ = params;
is_main_window_ = true;
jochen (gone - plz use gerrit) 2016/03/04 12:36:55 there can only be one main window, but now all OOP
Łukasz Anforowicz 2016/03/04 20:49:45 I've addressed your other, similar question here:
- ForceResizeRenderView(
- render_view(),
- WebSize(params.initial_size.width(), params.initial_size.height()));
- SetFocus(proxy_, true);
-
test_runner::WebTestInterfaces* interfaces =
LayoutTestRenderProcessObserver::GetInstance()->test_interfaces();
interfaces->SetTestIsRunning(true);
@@ -992,6 +985,16 @@ void BlinkTestRunner::OnSetTestConfiguration(
params.enable_pixel_dumping);
}
+void BlinkTestRunner::OnSetTestConfiguration(
+ const ShellTestConfiguration& params) {
+ OnReplicateTestConfiguration(params);
+
+ ForceResizeRenderView(
+ render_view(),
+ WebSize(params.initial_size.width(), params.initial_size.height()));
+ SetFocus(proxy_, true);
+}
+
void BlinkTestRunner::OnSessionHistory(
const std::vector<int>& routing_ids,
const std::vector<std::vector<PageState>>& session_histories,

Powered by Google App Engine
This is Rietveld 408576698