Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 175006: Wait correctly for all navigations that will happen in ErrorPageTest. (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Wait correctly for all navigations that will happen in ErrorPageTest. Will it kill flakiness? I'm undisabling some tests on Linux to find out. TEST=none http://crbug.com/19361 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M chrome/browser/errorpage_uitest.cc View 5 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
11 years, 3 months ago (2009-08-27 23:38:38 UTC) #1
darin (slow to review)
LGTM!
11 years, 3 months ago (2009-08-27 23:40:12 UTC) #2
huanr
11 years, 3 months ago (2009-08-27 23:45:42 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698