Move scoped_nsobject from base/memory to base/mac.

Move scoped_nsobject from base/memory to base/mac.

So it's next to scoped_cftyperef.h. Also move both scoped_nsobject and
ScopedCFTypeRef to namespace base.

BUG=251957
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207616

[Mark Mentovai, 2013-06-20 18:53:22]

LGTM

https://codereview.chromium.org/17500005/diff/6001/base/mac/scoped_cftyperef.h
File base/mac/scoped_cftyperef.h (right):

https://codereview.chromium.org/17500005/diff/6001/base/mac/scoped_cftyperef....
base/mac/scoped_cftyperef.h:31: class ScopedCFTypeRef {
The CL description says scoped_cftyperef but (for now?) it’s named
ScopedCFTypeRef. Fix the description.

https://codereview.chromium.org/17500005/diff/6001/base/memory/scoped_nsobject.h
File base/memory/scoped_nsobject.h (right):

https://codereview.chromium.org/17500005/diff/6001/base/memory/scoped_nsobjec...
base/memory/scoped_nsobject.h:11: using base::scoped_nsobject;
Blank line before me.

[Nico, 2013-06-20 18:56:00]

Thanks!

https://codereview.chromium.org/17500005/diff/6001/base/mac/scoped_cftyperef.h
File base/mac/scoped_cftyperef.h (right):

https://codereview.chromium.org/17500005/diff/6001/base/mac/scoped_cftyperef....
base/mac/scoped_cftyperef.h:31: class ScopedCFTypeRef {
On 2013/06/20 18:53:22, Mark Mentovai wrote:
> The CL description says scoped_cftyperef but (for now?) it’s named
> ScopedCFTypeRef. Fix the description.

Done.

https://codereview.chromium.org/17500005/diff/6001/base/memory/scoped_nsobject.h
File base/memory/scoped_nsobject.h (right):

https://codereview.chromium.org/17500005/diff/6001/base/memory/scoped_nsobjec...
base/memory/scoped_nsobject.h:11: using base::scoped_nsobject;
On 2013/06/20 18:53:22, Mark Mentovai wrote:
> Blank line before me.

Done.

[commit-bot: I haz the power, 2013-06-20 22:02:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/17500005/10002

[Nico, 2013-06-20 22:42:27]

Committed patchset #4 manually as r207616 (presubmit successful).

[stuartmorgan, 2013-06-21 12:41:18]

https://codereview.chromium.org/17500005/diff/10002/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/17500005/diff/10002/base/base.gyp#newcode810
base/base.gyp:810: # by file name rules).
Don't you need to update this list, so we don't lose the unit test on iOS?

https://codereview.chromium.org/17500005/diff/10002/base/base.gypi
File base/base.gypi (right):

https://codereview.chromium.org/17500005/diff/10002/base/base.gypi#newcode734
base/base.gypi:734: # by file name rules).
Same here? Not sure why the iOS build didn't break...

[stuartmorgan, 2013-06-21 12:48:46]

On 2013/06/21 12:41:18, stuartmorgan wrote:
> Same here? Not sure why the iOS build didn't break...

I guess we must not yet have anything upstream building that uses it, except the
unit test :(

[Mark Mentovai, 2013-06-21 13:34:27]

https://codereview.chromium.org/17500005/diff/10002/base/base.gypi
File base/base.gypi (right):

https://codereview.chromium.org/17500005/diff/10002/base/base.gypi#newcode734
base/base.gypi:734: # by file name rules).
stuartmorgan wrote:
> Same here? Not sure why the iOS build didn't break...

Because it’s a header.

Still should list it here.

[stuartmorgan, 2013-06-21 13:44:42]

On 2013/06/21 13:34:27, Mark Mentovai wrote:
> Because it’s a header.

Doh!