chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm - Issue 17500003: Close web contents modal dialogs on content load start

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

Issue 17500003: Close web contents modal dialogs on content load start (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix for autocheckout dialog breakage Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('K') | « chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h ('k') | chrome/browser/ui/tab_modal_confirm_dialog_delegate.h » ('j') | components/web_modal/web_contents_modal_dialog_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

index df302dfc573a304edc28ad3654dce2d31280323b..4f7e1da2013e89cabb58176ed013e262410709a8 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

@@ -78,6 +78,14 @@ NativeWebContentsModalDialog ConstrainedWindowMac::GetNativeDialog() {

return this;

}

+void ConstrainedWindowMac::SetInhibitCloseOnLoadStart(bool inhibit) {

+ WebContentsModalDialogManager* web_contents_modal_dialog_manager =

+ WebContentsModalDialogManager::FromWebContents(web_contents_);

+ web_contents_modal_dialog_manager->SetInhibitCloseOnLoadStart(

+ GetNativeDialog(),

+ inhibit);

NSWindow* ConstrainedWindowMac::GetParentWindow() const {

// Tab contents in a tabbed browser may not be inside a window. For this

// reason use a browser window if possible.