chrome/browser/printing/print_view_manager.cc - Issue 17500003: Close web contents modal dialogs on content load start

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 17500003: Close web contents modal dialogs on content load start (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't observe nav committed for initiator tab Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_view_manager.cc

diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc

index f5efeb714f15704be6e2b0936599260865609571..2aca362e70232b969857d8eccc5f74e18c238cf5 100644

--- a/chrome/browser/printing/print_view_manager.cc

+++ b/chrome/browser/printing/print_view_manager.cc

@@ -153,7 +153,6 @@ void PrintViewManager::PrintPreviewForWebNode() {

void PrintViewManager::PrintPreviewDone() {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- DCHECK_NE(NOT_PREVIEWING, print_preview_state_);

if (print_preview_state_ == SCRIPTED_PREVIEW) {

ScriptedPrintPreviewClosureMap& map =