chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc - Issue 17500003: Close web contents modal dialogs on content load start

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

Issue 17500003: Close web contents modal dialogs on content load start (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix crash accepting OS X report form warning dialog Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

diff --git a/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc b/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

index 8c37a05959e3cceef0c97a560b8cea270138ea48..2d69016485054338e1554bec61abd8e8c99b9517 100644

--- a/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

+++ b/chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc

@@ -53,7 +53,7 @@ TabModalConfirmDialogWebUI::TabModalConfirmDialogWebUI(

constrained_web_dialog_delegate_ =

CreateConstrainedWebDialog(profile, this, NULL, web_contents);

- delegate_->set_close_delegate(this);

+ delegate_->set_operations_delegate(this);

}

ui::ModalType TabModalConfirmDialogWebUI::GetDialogModalType() const {

@@ -95,7 +95,7 @@ void TabModalConfirmDialogWebUI::OnDialogClosed(

NOTREACHED() << "Missing or unreadable response from dialog";

}

- delegate_->set_close_delegate(NULL);

+ delegate_->set_operations_delegate(NULL);

if (accepted)

delegate_->Accept();

else