Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1749853002: [interpreter] Unbreak test262 tests using constants. (Closed)

Created:
4 years, 9 months ago by oth
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Unbreak test262 tests using constants. Fixes a bug in the constant pool padding calculation. BUG=v8:4680 LOG=N Committed: https://crrev.com/318a09ea5985139c0984088c55a5d0f5e8c1f183 Cr-Commit-Position: refs/heads/master@{#34403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M src/interpreter/constant-array-builder.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
oth
Ross, PTAL. Thanks.
4 years, 9 months ago (2016-02-29 18:47:59 UTC) #1
oth
4 years, 9 months ago (2016-02-29 19:21:34 UTC) #3
rmcilroy
LGTM, thanks
4 years, 9 months ago (2016-03-01 05:00:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749853002/1
4 years, 9 months ago (2016-03-01 18:03:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 18:05:11 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 18:05:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/318a09ea5985139c0984088c55a5d0f5e8c1f183
Cr-Commit-Position: refs/heads/master@{#34403}

Powered by Google App Engine
This is Rietveld 408576698