Issue 1749813003: Make 'generate_summaries' depend on the whole skd/lib folder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1749813003: Make 'generate_summaries' depend on the whole skd/lib folder. (Closed)

Created:
4 years, 9 months ago by scheglov

Modified:
4 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make 'generate_summaries' depend on the whole skd/lib folder. R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/93393bba3b2d93fd66f14e2cb2c26839f5496ce8

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	utils/dartanalyzer/dartanalyzer.gyp	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

https://codereview.chromium.org/1749813003/diff/1/utils/dartanalyzer/dartanalyzer.gyp File utils/dartanalyzer/dartanalyzer.gyp (right): https://codereview.chromium.org/1749813003/diff/1/utils/dartanalyzer/dartanalyzer.gyp#newcode38 utils/dartanalyzer/dartanalyzer.gyp:38: '<!@(["python", "../../tools/list_files.py", "\\.dart$", "../../sdk/lib"])', We have a problem when ...

4 years, 9 months ago (2016-03-01 08:27:01 UTC) #2

scheglov

4 years, 9 months ago (2016-03-01 19:17:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
93393bba3b2d93fd66f14e2cb2c26839f5496ce8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages