Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1749813002: Fixes hidden "Set Default Browser" button when group policy is enabled (Closed)

Created:
4 years, 9 months ago by Patrick Monette
Modified:
4 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-options_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes hidden "Set Default Browser" button when group policy is enabled The user will now be able to click the button when "Set Google Chrome as the default browser" is Enabled. BUG=590781 Committed: https://crrev.com/4c79a5837aba384a557bb02f26a5ad4e37c91a21 Cr-Commit-Position: refs/heads/master@{#378273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/browser/ui/webui/options/browser_options_handler.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_default_browser_handler.cc View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Patrick Monette
PTAL
4 years, 9 months ago (2016-02-29 17:57:14 UTC) #2
Dan Beam
lgtm!
4 years, 9 months ago (2016-02-29 20:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749813002/1
4 years, 9 months ago (2016-02-29 20:29:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 21:15:54 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 21:18:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c79a5837aba384a557bb02f26a5ad4e37c91a21
Cr-Commit-Position: refs/heads/master@{#378273}

Powered by Google App Engine
This is Rietveld 408576698