Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1749753002: Fix bug when @protected is not on a class member (issue 25882) (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug when @protected is not on a class member (issue 25882) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0185ca70fd06fa5e485e82a39198b1b6526d1a69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-02-29 16:29:09 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-02-29 16:35:19 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-02-29 16:40:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0185ca70fd06fa5e485e82a39198b1b6526d1a69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698