Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1749713002: Allow simple selectors after ::content for compat. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow simple selectors after ::content for compat. Allow simple selectors which are not pseudo elements after ::content in compound selectors. Polymer 0.5 content sometimes use ::content[attr] instead of [attr]::content. This was made invalid with r369760. R=timloh@chromium.org BUG=589252 Committed: https://crrev.com/b9661ac4a6e7f0cfcd9b6fc8b25b074cac3b7bed Cr-Commit-Position: refs/heads/master@{#378331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-not-last.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/content-pseudo-element-not-last-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 9 months ago (2016-02-29 14:56:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749713002/1
4 years, 9 months ago (2016-02-29 14:56:21 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 16:00:51 UTC) #5
Timothy Loh
On 2016/02/29 14:56:14, rune wrote: > ptal seems reasonable, lgtm
4 years, 9 months ago (2016-02-29 23:38:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749713002/1
4 years, 9 months ago (2016-02-29 23:43:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 00:06:13 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 00:07:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9661ac4a6e7f0cfcd9b6fc8b25b074cac3b7bed
Cr-Commit-Position: refs/heads/master@{#378331}

Powered by Google App Engine
This is Rietveld 408576698