Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1749703002: Remove fgas_base.h and IWYU (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Actually remove file #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -43 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxcrt/fx_ucd.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fgas/include/fx_rbk.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fgas/include/fx_ucd.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_algorithm.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_codepage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_encode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_memory.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_stream.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_system.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_utils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D xfa/src/fgas/src/fgas_base.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
M xfa/src/fgas/src/font/fx_fontutils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fgas/src/font/fx_fontutils.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fgas/src/font/fx_gefont.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fgas/src/font/fx_stdfontmgr.h View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fgas/src/font/fx_stdfontmgr.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fgas/src/layout/fx_linebreak.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/layout/fx_rtfbreak.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_textbreak.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_textbreak.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_unicode.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_unicode.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fgas/src/localization/fx_datetime.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M xfa/src/fgas/src/localization/fx_locale.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/localization/fx_localemgr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fgas/src/xml/fx_sax_imp.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-02-29 14:43:54 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1749703002/diff/20001/core/include/fxcrt/fx_ucd.h File core/include/fxcrt/fx_ucd.h (right): https://codereview.chromium.org/1749703002/diff/20001/core/include/fxcrt/fx_ucd.h#newcode14 core/include/fxcrt/fx_ucd.h:14: Nit: stray file? But OK. https://codereview.chromium.org/1749703002/diff/20001/xfa/src/fgas/src/localization/fx_datetime.cpp File xfa/src/fgas/src/localization/fx_datetime.cpp ...
4 years, 9 months ago (2016-02-29 17:24:46 UTC) #3
dsinclair
https://codereview.chromium.org/1749703002/diff/20001/core/include/fxcrt/fx_ucd.h File core/include/fxcrt/fx_ucd.h (right): https://codereview.chromium.org/1749703002/diff/20001/core/include/fxcrt/fx_ucd.h#newcode14 core/include/fxcrt/fx_ucd.h:14: On 2016/02/29 17:24:46, Tom Sepez wrote: > Nit: stray ...
4 years, 9 months ago (2016-02-29 18:13:04 UTC) #4
dsinclair
4 years, 9 months ago (2016-02-29 18:13:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a5585569e274fcff8ae106e412eb764c2787cb3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698