Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1749663002: [api] Assume that v8/include is in the include path for all public headers (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Assume that v8/include is in the include path for all public headers Probably easier to use for embedders. BUG= R=ulan@chromium.org Committed: https://crrev.com/e8c914f18fd88cd58aaaf5d8cee53b9e57477b52 Cr-Commit-Position: refs/heads/master@{#34357}

Patch Set 1 #

Patch Set 2 : udpates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M BUILD.gn View 1 2 3 5 chunks +9 lines, -0 lines 0 comments Download
M include/libplatform/libplatform.h View 1 chunk +1 line, -1 line 0 comments Download
M include/v8-experimental.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-02-29 08:41:52 UTC) #1
ulan
lgtm
4 years, 9 months ago (2016-02-29 08:46:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749663002/1
4 years, 9 months ago (2016-02-29 08:48:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/11059)
4 years, 9 months ago (2016-02-29 08:56:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749663002/20001
4 years, 9 months ago (2016-02-29 10:01:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/11064)
4 years, 9 months ago (2016-02-29 10:08:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749663002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749663002/60001
4 years, 9 months ago (2016-02-29 10:53:59 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-02-29 11:02:58 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 11:03:08 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e8c914f18fd88cd58aaaf5d8cee53b9e57477b52
Cr-Commit-Position: refs/heads/master@{#34357}

Powered by Google App Engine
This is Rietveld 408576698