Store URLs in WebappDataStorage, and purge them when history is cleared.

chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 
 import android.content.Context;
@@ skipping 45 matching lines @@
     @Feature({"Webapp"})
     public void testBackwardCompatibility() {
         assertEquals(REGISTRY_FILE_NAME, WebappRegistry.REGISTRY_FILE_NAME);
         assertEquals(KEY_WEBAPP_SET, WebappRegistry.KEY_WEBAPP_SET);
         assertEquals(KEY_LAST_CLEANUP, WebappRegistry.KEY_LAST_CLEANUP);
     }
 
     @Test
     @Feature({"Webapp"})
     public void testWebappRegistrationAddsToSharedPrefs() throws Exception {
-        WebappRegistry.registerWebapp(Robolectric.application, "test");
+        WebappRegistry.registerWebapp(Robolectric.application, "test", "https://www.google.com");
         BackgroundShadowAsyncTask.runBackgroundTasks();
 
         Set<String> actual = mSharedPreferences.getStringSet(
                 WebappRegistry.KEY_WEBAPP_SET, Collections.<String>emptySet());
         assertEquals(1, actual.size());
         assertTrue(actual.contains("test"));
     }
 
     @Test
     @Feature({"Webapp"})
-    public void testWebappRegistrationUpdatesLastUsed() throws Exception {
+    public void testWebappRegistrationUpdatesLastUsedAndOrigin() throws Exception {
         long before = System.currentTimeMillis();
-        WebappRegistry.registerWebapp(Robolectric.application, "test");
+        final String origin = "http://drive.google.com";
+
+        WebappRegistry.registerWebapp(Robolectric.application, "test", origin);
         BackgroundShadowAsyncTask.runBackgroundTasks();
         long after = System.currentTimeMillis();
 
         SharedPreferences webAppPrefs = Robolectric.application.getSharedPreferences(
                 WebappDataStorage.SHARED_PREFS_FILE_PREFIX + "test", Context.MODE_PRIVATE);
         long actual = webAppPrefs.getLong(WebappDataStorage.KEY_LAST_USED,
                 WebappDataStorage.INVALID_LAST_USED);
+        String webAppOrigin = webAppPrefs.getString(WebappDataStorage.KEY_ORIGIN_URL,
+                WebappDataStorage.INVALID_ORIGIN_URL);
         assertTrue("Timestamp is out of range", before <= actual && actual <= after);
+        assertEquals(origin, webAppOrigin);
     }
 
     @Test
     @Feature({"Webapp"})
     public void testWebappIdsRetrieval() throws Exception {
         final Set<String> expected = addWebappsToRegistry("first", "second");
 
         WebappRegistry.getRegisteredWebappIds(Robolectric.application,
                 new WebappRegistry.FetchCallback() {
                     @Override
@@ skipping 20 matching lines @@
                         mCallbackCalled = true;
                         assertEquals(expected, actual);
                     }
                 });
         BackgroundShadowAsyncTask.runBackgroundTasks();
         Robolectric.runUiThreadTasks();
 
         assertTrue(mCallbackCalled);
         mCallbackCalled = false;
 
-        WebappRegistry.registerWebapp(Robolectric.application, "second");
+        WebappRegistry.registerWebapp(Robolectric.application, "second", "https://www.google.com");
         BackgroundShadowAsyncTask.runBackgroundTasks();
 
         // A copy of the expected set needs to be made as the SharedPreferences is using the copy
         // that was paassed to it.
         final Set<String> secondExpected = new HashSet<String>(expected);
         secondExpected.add("second");
 
         WebappRegistry.getRegisteredWebappIds(Robolectric.application,
                 new WebappRegistry.FetchCallback() {
                     @Override
@@ skipping 138 matching lines @@
         assertTrue(actual.isEmpty());
 
         long actualLastUsed = webAppPrefs.getLong(WebappDataStorage.KEY_LAST_USED,
                 WebappDataStorage.INVALID_LAST_USED);
         assertEquals(WebappDataStorage.INVALID_LAST_USED, actualLastUsed);
 
         long lastCleanup = mSharedPreferences.getLong(WebappRegistry.KEY_LAST_CLEANUP, -1);
         assertEquals(currentTime, lastCleanup);
     }
 
+    @Test
+    @Feature({"Webapp"})
+    public void testClearWebappHistoryRunsCallback() throws Exception {
+        WebappRegistry.clearWebappHistory(Robolectric.application, new Runnable() {
+            @Override
+            public void run() {
+                mCallbackCalled = true;
+            }
+        });
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+        Robolectric.runUiThreadTasks();
+
+        assertTrue(mCallbackCalled);
+    }
+
+    @Test
+    @Feature({"Webapp"})
+    public void testClearWebappHistory() throws Exception {
+        final String webappOrigin1 =  "https://www.google.com";
+        final String webappOrigin2 =  "https://drive.google.com";
+        WebappRegistry.registerWebapp(Robolectric.application, "webapp1", webappOrigin1);
+        WebappRegistry.registerWebapp(Robolectric.application, "webapp2", webappOrigin2);
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+
+        SharedPreferences webapp1Prefs = Robolectric.application.getSharedPreferences(
+                WebappDataStorage.SHARED_PREFS_FILE_PREFIX + "webapp1", Context.MODE_PRIVATE);
+        SharedPreferences webapp2Prefs = Robolectric.application.getSharedPreferences(
+                WebappDataStorage.SHARED_PREFS_FILE_PREFIX + "webapp2", Context.MODE_PRIVATE);
+
+        WebappRegistry.clearWebappHistory(Robolectric.application, null);
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+
+        Set<String> actual = mSharedPreferences.getStringSet(
+                WebappRegistry.KEY_WEBAPP_SET, Collections.<String>emptySet());
+        assertEquals(2, actual.size());
+        assertTrue(actual.contains("webapp1"));

[gone, 2016/03/08 23:03:52]

Should this check for equality with TextUtils.equals() instead of checking for
contains()?

[dominickn, 2016/03/09 08:18:33]

I just followed what was already in this test - happy to change it to
TextUtils.equals() if you think that's better.

[gone, 2016/03/10 23:27:21]

Acknowledged.

+        assertTrue(actual.contains("webapp2"));
+
+        // Verify that the last used time for both web apps is WebappDataStorage.NULL_LAST_USED.
+        long actualLastUsed = webapp1Prefs.getLong(
+                WebappDataStorage.KEY_LAST_USED, WebappDataStorage.NULL_LAST_USED);
+        assertEquals(WebappDataStorage.NULL_LAST_USED, actualLastUsed);
+        actualLastUsed = webapp2Prefs.getLong(
+                WebappDataStorage.KEY_LAST_USED, WebappDataStorage.NULL_LAST_USED);
+        assertEquals(WebappDataStorage.NULL_LAST_USED, actualLastUsed);
+
+        // Verify that the origin URL for both web apps is WebappDataStorage.INVALID_ORIGIN_URL.
+        String actualOriginUrl = webapp1Prefs.getString(
+                WebappDataStorage.KEY_ORIGIN_URL, WebappDataStorage.INVALID_ORIGIN_URL);
+        assertEquals(WebappDataStorage.INVALID_ORIGIN_URL, actualOriginUrl);
+        actualOriginUrl = webapp2Prefs.getString(
+                WebappDataStorage.KEY_ORIGIN_URL, WebappDataStorage.INVALID_ORIGIN_URL);
+        assertEquals(WebappDataStorage.INVALID_ORIGIN_URL, actualOriginUrl);
+    }
+
+    @Test
+    @Feature({"Webapp"})
+    public void testOpenAfterClearWebappHistory() throws Exception {
+        final String webappOrigin =  "https://www.google.com";
+        WebappRegistry.registerWebapp(Robolectric.application, "webapp", webappOrigin);
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+
+        SharedPreferences webappPrefs = Robolectric.application.getSharedPreferences(
+                WebappDataStorage.SHARED_PREFS_FILE_PREFIX + "webapp", Context.MODE_PRIVATE);
+
+        WebappRegistry.clearWebappHistory(Robolectric.application, null);
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+
+        // Open the webapp up and set the origin.
+        WebappDataStorage.open(Robolectric.application, "webapp");
+        WebappDataStorage.updateOriginUrl(Robolectric.application, "webapp", webappOrigin);
+        BackgroundShadowAsyncTask.runBackgroundTasks();
+
+        // Verify that the last used time is valid and the origin URL is updated.
+        long actualLastUsed = webappPrefs.getLong(
+                WebappDataStorage.KEY_LAST_USED, WebappDataStorage.INVALID_LAST_USED);
+        assertTrue(WebappDataStorage.INVALID_LAST_USED != actualLastUsed);
+        assertTrue(WebappDataStorage.NULL_LAST_USED != actualLastUsed);
+        String actualOriginUrl = webappPrefs.getString(
+                WebappDataStorage.KEY_ORIGIN_URL, WebappDataStorage.INVALID_ORIGIN_URL);
+        assertEquals(webappOrigin, actualOriginUrl);
+    }
+
+
     private Set<String> addWebappsToRegistry(String... webapps) {
         final Set<String> expected = new HashSet<String>(Arrays.asList(webapps));
         mSharedPreferences.edit()
                 .putStringSet(WebappRegistry.KEY_WEBAPP_SET, expected)
                 .commit();
         return expected;
     }
 
     private Set<String> getRegisteredWebapps() {
         return mSharedPreferences.getStringSet(
                 WebappRegistry.KEY_WEBAPP_SET, Collections.<String>emptySet());
     }
-}
+}