Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1749593002: [Media Router WebUI] Remove black rectangles in print preview. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Remove black rectangles in print preview. This is resolved by setting the background to white. It was introduced with the addition of the shadow styling. BUG=590635 Committed: https://crrev.com/d2cfb0a16cc86ef3f900a0011bed4d0996764bdb Cr-Commit-Position: refs/heads/master@{#378368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/media_router/media_router.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
apacible
PTAL, thanks! https://screenshot.googleplex.com/x4FUuYfO5b4.png
4 years, 9 months ago (2016-02-29 16:48:38 UTC) #3
apacible
4 years, 9 months ago (2016-02-29 16:48:51 UTC) #5
imcheng
lgtm
4 years, 9 months ago (2016-02-29 18:21:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749593002/1
4 years, 9 months ago (2016-02-29 18:29:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/181386) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 9 months ago (2016-02-29 18:35:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749593002/1
4 years, 9 months ago (2016-03-01 00:42:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 01:59:06 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 02:00:23 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2cfb0a16cc86ef3f900a0011bed4d0996764bdb
Cr-Commit-Position: refs/heads/master@{#378368}

Powered by Google App Engine
This is Rietveld 408576698