Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1749583003: Revert of DM: disable ignored and very niche configs on bots. (Closed)

Created:
4 years, 9 months ago by mtklein
Modified:
4 years, 9 months ago
Reviewers:
hal.canary, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of DM: disable ignored and very niche configs on bots. (patchset #1 id:1 of https://codereview.chromium.org/1745073002/ ) Reason for revert: remote-8888 just caught a bug. I am disproved. Original issue's description: > DM: disable ignored and very niche configs on bots. > > These are all probably just wasting time: > - upright-matrix-{8888,gpu} and remote[_cache] are ignored in Gold > - sp and 2ndpic test very niche areas of SkPicture > that are not under active change > - twice-8888 was never useful... the twice- via was meant for local > testing of GPU batching / caching. Drawing into 8888 was moot. > > These configs are all useful to keep around for local testing, but probably are > not worth the extra runtime or especially burden to have to think about them. > > If we should happen to stumble into bugs these configs would have caught, > let's add them back with a note about those bugs to justify their need to run. > I'm not convinced any exist today. > > This cuts ~30s off the CQ. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745073002 > > Committed: https://skia.googlesource.com/skia/+/7b6d3a30cf18377935c800603fc00fe0966d15de TBR=halcanary@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/dd54e5d557ad45cdd819bdfe43556d9eae3616c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1289 lines, -430 lines) Patch
M tools/dm_flags.json View 20 chunks +1273 lines, -429 lines 0 comments Download
M tools/dm_flags.py View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of DM: disable ignored and very niche configs on bots.
4 years, 9 months ago (2016-02-29 17:50:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749583003/1
4 years, 9 months ago (2016-02-29 17:51:05 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 17:51:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd54e5d557ad45cdd819bdfe43556d9eae3616c5

Powered by Google App Engine
This is Rietveld 408576698