Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 174953005: Clean up compute_interfaces_info.py and generate_global_constructors.py (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Clean up compute_interfaces_info.py and generate_global_constructors.py This post-split CL: 1. adds documentation and renames functions, 2. makes the call to generate_global_constructors generic  (so we don't need to add a flag for each global scope!), 3. only passes main interfaces to generate_global_constructors;  this means we don't need to check for partial interfaces,  and means that in a followup I can remove [NoInterfaceObject]  from testing IDLs and implemented interfaces, since we now just don't feed  these into generate_global_constructors! 2 followup CLs: * Split out EventInterfaces.in * Remove [NoInterfaceObject] from tests and dependencies  (no longer needed, as discussed above) Followup to: Split generate_global_constructors.py from compute_interfaces_info.py https://codereview.chromium.org/173503009/ Split from: Split generate_global_constructors.py out of compute_dependencies.py https://codereview.chromium.org/173803006/ BUG=341748 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168126

Patch Set 1 #

Total comments: 7

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -75 lines) Patch
M Source/bindings/generated_bindings.gyp View 1 2 5 chunks +20 lines, -15 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info.py View 1 10 chunks +70 lines, -26 lines 0 comments Download
M Source/bindings/scripts/generate_global_constructors.py View 1 2 4 chunks +17 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
Here's 3/3. You're right, it's much easier to review the logic changes when the renaming ...
6 years, 10 months ago (2014-02-21 13:29:17 UTC) #1
haraken
LGTM https://codereview.chromium.org/174953005/diff/1/Source/bindings/scripts/compute_interfaces_info.py File Source/bindings/scripts/compute_interfaces_info.py (right): https://codereview.chromium.org/174953005/diff/1/Source/bindings/scripts/compute_interfaces_info.py#newcode59 Source/bindings/scripts/compute_interfaces_info.py:59: 'inherited_extended_attributes': inherited extended attributes BTW, did you support ...
6 years, 10 months ago (2014-02-21 13:37:06 UTC) #2
Nils Barth (inactive)
Thanks! One naming reply. https://codereview.chromium.org/174953005/diff/1/Source/bindings/scripts/compute_interfaces_info.py File Source/bindings/scripts/compute_interfaces_info.py (right): https://codereview.chromium.org/174953005/diff/1/Source/bindings/scripts/compute_interfaces_info.py#newcode59 Source/bindings/scripts/compute_interfaces_info.py:59: 'inherited_extended_attributes': inherited extended attributes On ...
6 years, 10 months ago (2014-02-21 13:51:57 UTC) #3
haraken
https://codereview.chromium.org/174953005/diff/1/Source/bindings/scripts/compute_interfaces_info.py File Source/bindings/scripts/compute_interfaces_info.py (right): https://codereview.chromium.org/174953005/diff/1/Source/bindings/scripts/compute_interfaces_info.py#newcode59 Source/bindings/scripts/compute_interfaces_info.py:59: 'inherited_extended_attributes': inherited extended attributes On 2014/02/21 13:51:57, Nils Barth ...
6 years, 10 months ago (2014-02-21 13:53:19 UTC) #4
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-02-28 09:35:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/174953005/100001
6 years, 9 months ago (2014-02-28 09:35:10 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 13:17:44 UTC) #7
Message was sent while issue was closed.
Change committed as 168126

Powered by Google App Engine
This is Rietveld 408576698