third_party/WebKit/LayoutTests/svg/custom/patterns-nested-no-geometry.svg - Issue 1749423005: Don't use a SubtreeLayoutScope object for SVG resource layout

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/custom/patterns-nested-no-geometry.svg

Issue 1749423005: Don't use a SubtreeLayoutScope object for SVG resource layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/custom/patterns-nested-no-geometry-expected.svg » ('j') | third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <svg width="100%" height="100%" xmlns="http://www.w3.org/2000/svg" xmlns:xlink=" http://www.w3.org/1999/xlink">

	2 <rect fill="url(#p1)" stroke="green" x="10" y="10" width="50" height="50"/>

	3 <pattern id="p2">

	4 <pattern id="p1">
	f(malita) 2016/03/02 18:24:50 One way to look at solving the problem within the One way to look at solving the problem within the current framework is that p2 should not attempt to layout p1 - it should only layout structural elements not definition elements. Definition elements get laid out on reference, so it should be safe to skip at this point, no? fs 2016/03/02 19:13:24 It can't be skipped always though I think (i.e whe Show quoted text On 2016/03/02 at 18:24:50, f(malita) wrote: > One way to look at solving the problem within the current framework is that p2 should not attempt to layout p1 - it should only layout structural elements not definition elements. Definition elements get laid out on reference, so it should be safe to skip at this point, no? It can't be skipped always though I think (i.e when there are no references to #p1), or we might end up with a dirty tree in the end?
	5 <rect fill="url(#p2)" x="10" y="10" width="200" height="200"/>

	6 </pattern>

	7 </pattern>

	8 </svg>

OLD	NEW