Implement BluetoothRemoteGattCharacteristicWin::StartNotifySession and related unit tests

device/bluetooth/bluetooth_low_energy_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_low_energy_win.h"
 
 #include <utility>
 
 #include "base/files/file.h"
 #include "base/logging.h"
@@ skipping 451 matching lines @@
   result->path =
       base::FilePath(std::wstring(device_interface_detail_data->DevicePath));
   if (!CollectBluetoothLowEnergyDeviceInstanceId(
           device_info_handle, &device_info_data, result, error)) {
     return false;
   }
   if (!CollectBluetoothLowEnergyDeviceFriendlyName(
           device_info_handle, &device_info_data, result, error)) {
     // Only fail if not the GATT service device interface, which doesn't have a
     // friendly name.
-    if (device_info_data.ClassGuid !=
+    if (device_interface_data->InterfaceClassGuid !=

[scheib, 2016/04/05 22:44:02]

Double check that you intend this change -- I don't yet see relevance to this
patch and didn't find discussion in previous comments. If it's just a related
bug fix consider explaining in change description or a stand alone patch.

[gogerald1, 2016/04/06 22:54:48]

Done. Split out

         GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE)
       return false;
   }
   if (!CollectBluetoothLowEnergyDeviceAddress(
           device_info_handle, &device_info_data, result, error)) {
     return false;
   }
   if (!CollectBluetoothLowEnergyDeviceStatus(
           device_info_handle, &device_info_data, result, error)) {
     return false;
@@ skipping 347 matching lines @@
   base::File file(service_path, base::File::FLAG_OPEN | base::File::FLAG_READ |
                                     base::File::FLAG_WRITE);
   if (!file.IsValid())
     return HRESULT_FROM_WIN32(ERROR_OPEN_FAILED);
 
   return BluetoothGATTSetCharacteristicValue(file.GetPlatformFile(),
                                              characteristic, new_value, NULL,
                                              BLUETOOTH_GATT_FLAG_NONE);
 }
 
+HRESULT BluetoothLowEnergyWrapper::RegisterGattEvents(
+    base::FilePath& service_path,
+    BTH_LE_GATT_EVENT_TYPE event_type,
+    PVOID event_parameter,
+    PFNBLUETOOTH_GATT_EVENT_CALLBACK callback,
+    PVOID context,
+    BLUETOOTH_GATT_EVENT_HANDLE* out_handle) {
+  base::File file(service_path, base::File::FLAG_OPEN | base::File::FLAG_READ);
+  if (!file.IsValid())
+    return HRESULT_FROM_WIN32(ERROR_OPEN_FAILED);
+  return BluetoothGATTRegisterEvent(file.GetPlatformFile(), event_type,
+                                    event_parameter, callback, context,
+                                    out_handle, BLUETOOTH_GATT_FLAG_NONE);
+}
+
+HRESULT BluetoothLowEnergyWrapper::UnregisterGattEvent(
+    BLUETOOTH_GATT_EVENT_HANDLE event_handle) {
+  return BluetoothGATTUnregisterEvent(event_handle, BLUETOOTH_GATT_FLAG_NONE);
+}
+
+HRESULT BluetoothLowEnergyWrapper::WriteDescriptorValue(
+    base::FilePath& service_path,
+    const PBTH_LE_GATT_DESCRIPTOR descriptor,
+    PBTH_LE_GATT_DESCRIPTOR_VALUE new_value) {
+  base::File file(service_path, base::File::FLAG_OPEN | base::File::FLAG_READ |
+                                    base::File::FLAG_WRITE);
+  if (!file.IsValid())
+    return HRESULT_FROM_WIN32(ERROR_OPEN_FAILED);
+  return BluetoothGATTSetDescriptorValue(file.GetPlatformFile(), descriptor,
+                                         new_value, BLUETOOTH_GATT_FLAG_NONE);
+}
+
 }  // namespace win
 }  // namespace device