Implement BluetoothRemoteGattCharacteristicWin::StartNotifySession and related unit tests

device/bluetooth/bluetooth_low_energy_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_low_energy_win.h"
 
 #include <utility>
 
 #include "base/files/file.h"
 #include "base/logging.h"
@@ skipping 819 matching lines @@
   base::File file(service_path, base::File::FLAG_OPEN | base::File::FLAG_READ |
                                     base::File::FLAG_WRITE);
   if (!file.IsValid())
     return HRESULT_FROM_WIN32(ERROR_OPEN_FAILED);
 
   return BluetoothGATTSetCharacteristicValue(file.GetPlatformFile(),
                                              characteristic, new_value, NULL,
                                              BLUETOOTH_GATT_FLAG_NONE);
 }
 
+HRESULT BluetoothLowEnergyWrapper::RegisterGattEvents(
+    base::FilePath& service_path,
+    BTH_LE_GATT_EVENT_TYPE event_type,
+    PVOID event_parameter,
+    PFNBLUETOOTH_GATT_EVENT_CALLBACK callback,
+    PVOID context,
+    BLUETOOTH_GATT_EVENT_HANDLE* out_handle) {
+  base::File file(service_path, base::File::FLAG_OPEN | base::File::FLAG_READ);

[ortuno, 2016/03/07 18:48:45]

I'm curious. If BluetoothLowEnergyWrapper is supposed to be a very light wrapper
around windows APIs why do you open the file here and not in the task manager?

[gogerald1, 2016/03/07 22:52:49]

Here open file opens a device in OS. It makes this interface self included and
convenient to implement corresponding fake interface.

[ortuno, 2016/03/08 00:05:36]

Ah that makes sense.

+  if (!file.IsValid())
+    return HRESULT_FROM_WIN32(ERROR_OPEN_FAILED);
+  return BluetoothGATTRegisterEvent(file.GetPlatformFile(), event_type,
+                                    event_parameter, callback, context,
+                                    out_handle, BLUETOOTH_GATT_FLAG_NONE);
+}
+
+HRESULT BluetoothLowEnergyWrapper::UnregisterGattEvent(
+    BLUETOOTH_GATT_EVENT_HANDLE event_handle) {
+  return BluetoothGATTUnregisterEvent(event_handle, BLUETOOTH_GATT_FLAG_NONE);
+}
+
 }  // namespace win
 }  // namespace device