linux_aura: Three fixes for switching themes.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 217 matching lines @@
           OptionsPage.navigateToPage('accounts');
           chrome.send('coreOptionsUserMetricsAction',
               ['Options_ManageAccounts']);
         };
       } else {
         $('import-data').onclick = function(event) {
           ImportDataOverlay.show();
           chrome.send('coreOptionsUserMetricsAction', ['Import_ShowDlg']);
         };
 
-        if ($('themes-GTK-button')) {
-          $('themes-GTK-button').onclick = function(event) {
-            chrome.send('themesSetGTK');
+        if ($('themes-Native-button')) {
+          $('themes-Native-button').onclick = function(event) {
+            chrome.send('themesSetNative');
           };
         }
       }
 
       // Default browser section.
       if (!cr.isChromeOS) {
         $('set-as-default-browser').onclick = function(event) {
           chrome.send('becomeDefaultBrowser');
         };
 
@@ skipping 856 matching lines @@
       for (var i = 0; i < $('profiles-list').dataModel.length; i++) {
         var profile = $('profiles-list').dataModel.item(i);
         if (profile.isCurrentProfile)
           return profile;
       }
 
       assert(false,
              'There should always be a current profile, but none found.');
     },
 
-    setGtkThemeButtonEnabled_: function(enabled) {
+    setNativeThemeButtonEnabled_: function(enabled) {
       if (!cr.isChromeOS && navigator.platform.match(/linux|BSD/i))

[Evan Stade, 2013/06/20 22:24:35]

can we just check if the button exists here instead of replicating the platform
check?

[Elliot Glaysher, 2013/06/21 17:58:45]

I am not good with Javascript. Is this what you wanted?

[Evan Stade, 2013/06/21 21:40:52]

yes

-        $('themes-GTK-button').disabled = !enabled;
+        $('themes-Native-button').disabled = !enabled;
     },
 
     setThemesResetButtonEnabled_: function(enabled) {
       $('themes-reset').disabled = !enabled;
     },
 
     /**
      * (Re)loads IMG element with current user account picture.
      * @private
      */
@@ skipping 328 matching lines @@
     'getCurrentProfile',
     'getStartStopSyncButton',
     'hideBluetoothSettings',
     'notifyInitializationComplete',
     'removeBluetoothDevice',
     'removeCloudPrintConnectorSection',
     'scrollToSection',
     'setAutoOpenFileTypesDisplayed',
     'setBluetoothState',
     'setFontSize',
-    'setGtkThemeButtonEnabled',
+    'setNativeThemeButtonEnabled',
     'setHighContrastCheckboxState',
     'setMetricsReportingCheckboxState',
     'setMetricsReportingSettingVisibility',
     'setPasswordGenerationSettingVisibility',
     'setProfilesInfo',
     'setSpokenFeedbackCheckboxState',
     'setThemesResetButtonEnabled',
     'setVirtualKeyboardCheckboxState',
     'setupCloudPrintConnectorSection',
     'setupPageZoomSelector',
@@ skipping 27 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });