linux_aura: Three fixes for switching themes.

linux_aura: Three fixes for switching themes.

Native system theming was badly hacked into ThemeService with ifdefs. This
correlates the code into its own file, which should be conditionally compiled
out.

When doing any switching of themes, we weren't notifying the non client view of
the change.

Make the options page in the linux_aura port behave the same way as in the GTK+
port.

BUG=130810
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208060

[Elliot Glaysher, 2013-06-20 20:14:22]

estade: theme and webui stuff
sky: views DRWH changes

[sky, 2013-06-20 20:19:10]

DRWH LGTM

[Evan Stade, 2013-06-20 22:24:35]

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/resources/...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/resources/...
chrome/browser/resources/options/browser_options.html:36: <button
id="themes-Native-button"
nit: no capitalization

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/resources/...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/resources/...
chrome/browser/resources/options/browser_options.js:1118: if (!cr.isChromeOS &&
navigator.platform.match(/linux|BSD/i))
can we just check if the button exists here instead of replicating the platform
check?

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/themes/the...
File chrome/browser/themes/theme_service_aurax11.cc (right):

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/themes/the...
chrome/browser/themes/theme_service_aurax11.cc:15: : ThemeService(),
is this necessary?

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/themes/the...
chrome/browser/themes/theme_service_aurax11.cc:19:
ThemeServiceAuraX11::~ThemeServiceAuraX11() {
{} on one line

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/themes/the...
File chrome/browser/themes/theme_service_aurax11.h (right):

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/themes/the...
chrome/browser/themes/theme_service_aurax11.h:34: bool use_system_theme_;
docs

https://codereview.chromium.org/17494005/diff/19001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/17494005/diff/19001/chrome/chrome_browser.gyp...
chrome/chrome_browser.gypi:2671: 'browser/themes/theme_service_aurax11.cc',
[...]aura_x11.cc?

[Elliot Glaysher, 2013-06-21 17:58:45]

estade: ptal

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/resources/...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/resources/...
chrome/browser/resources/options/browser_options.js:1118: if (!cr.isChromeOS &&
navigator.platform.match(/linux|BSD/i))
On 2013/06/20 22:24:35, Evan Stade wrote:
> can we just check if the button exists here instead of replicating the
platform
> check?

I am not good with Javascript. Is this what you wanted?

https://codereview.chromium.org/17494005/diff/19001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/17494005/diff/19001/chrome/chrome_browser.gyp...
chrome/chrome_browser.gypi:2671: 'browser/themes/theme_service_aurax11.cc',
On 2013/06/20 22:24:35, Evan Stade wrote:
> [...]aura_x11.cc?

No, aurax11 is the proper suffix that is filtered on in
build/filename_rules.gypi.

[Evan Stade, 2013-06-21 21:40:52]

lgtm

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/resources/...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/17494005/diff/19001/chrome/browser/resources/...
chrome/browser/resources/options/browser_options.js:1118: if (!cr.isChromeOS &&
navigator.platform.match(/linux|BSD/i))
On 2013/06/21 17:58:45, Elliot Glaysher wrote:
> On 2013/06/20 22:24:35, Evan Stade wrote:
> > can we just check if the button exists here instead of replicating the
> platform
> > check?
> 
> I am not good with Javascript. Is this what you wanted?

yes

[commit-bot: I haz the power, 2013-06-21 21:49:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/17494005/44003

[commit-bot: I haz the power, 2013-06-22 01:30:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/17494005/44003

[commit-bot: I haz the power, 2013-06-22 02:44:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/17494005/44003

[commit-bot: I haz the power, 2013-06-22 03:07:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/17494005/44003

[commit-bot: I haz the power, 2013-06-22 03:20:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/17494005/44003

[commit-bot: I haz the power, 2013-06-22 03:35:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/17494005/44003

[commit-bot: I haz the power, 2013-06-22 03:43:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/17494005/44003

[commit-bot: I haz the power, 2013-06-22 15:39:18]

Change committed as 208060