Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

Issue 1749383002: Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl through WebWidget down to… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 void notifyCompositorAnimationFinished(int groupId) override { }; 84 void notifyCompositorAnimationFinished(int groupId) override { };
85 void notifyCompositorAnimationAborted(int groupId) override { }; 85 void notifyCompositorAnimationAborted(int groupId) override { };
86 void layerForCompositedScrollingDidChange(CompositorAnimationTimeline*) over ride { }; 86 void layerForCompositedScrollingDidChange(CompositorAnimationTimeline*) over ride { };
87 87
88 virtual void contentAreaWillPaint() const { } 88 virtual void contentAreaWillPaint() const { }
89 virtual void mouseEnteredContentArea() const { } 89 virtual void mouseEnteredContentArea() const { }
90 virtual void mouseExitedContentArea() const { } 90 virtual void mouseExitedContentArea() const { }
91 virtual void mouseMovedInContentArea() const { } 91 virtual void mouseMovedInContentArea() const { }
92 virtual void mouseEnteredScrollbar(Scrollbar&) const { } 92 virtual void mouseEnteredScrollbar(Scrollbar&) const { }
93 virtual void mouseExitedScrollbar(Scrollbar&) const { } 93 virtual void mouseExitedScrollbar(Scrollbar&) const { }
94 virtual void willStartLiveResize() { }
95 virtual void updateAfterLayout() { } 94 virtual void updateAfterLayout() { }
96 virtual void contentsResized() const { } 95 virtual void contentsResized() const { }
97 virtual void willEndLiveResize() { }
98 virtual void contentAreaDidShow() const { } 96 virtual void contentAreaDidShow() const { }
99 virtual void contentAreaDidHide() const { } 97 virtual void contentAreaDidHide() const { }
100 98
101 virtual void finishCurrentScrollAnimations() { } 99 virtual void finishCurrentScrollAnimations() { }
102 100
103 virtual void didAddVerticalScrollbar(Scrollbar&) { } 101 virtual void didAddVerticalScrollbar(Scrollbar&) { }
104 virtual void willRemoveVerticalScrollbar(Scrollbar&) { } 102 virtual void willRemoveVerticalScrollbar(Scrollbar&) { }
105 virtual void didAddHorizontalScrollbar(Scrollbar&) { } 103 virtual void didAddHorizontalScrollbar(Scrollbar&) { }
106 virtual void willRemoveHorizontalScrollbar(Scrollbar&) { } 104 virtual void willRemoveHorizontalScrollbar(Scrollbar&) { }
107 105
(...skipping 13 matching lines...) Expand all
121 float clampScrollPosition(ScrollbarOrientation, float) const; 119 float clampScrollPosition(ScrollbarOrientation, float) const;
122 120
123 RawPtrWillBeMember<ScrollableArea> m_scrollableArea; 121 RawPtrWillBeMember<ScrollableArea> m_scrollableArea;
124 float m_currentPosX; // We avoid using a FloatPoint in order to reduce 122 float m_currentPosX; // We avoid using a FloatPoint in order to reduce
125 float m_currentPosY; // subclass code complexity. 123 float m_currentPosY; // subclass code complexity.
126 }; 124 };
127 125
128 } // namespace blink 126 } // namespace blink
129 127
130 #endif // ScrollAnimatorBase_h 128 #endif // ScrollAnimatorBase_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698