Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Side by Side Diff: third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

Issue 1749383002: Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl through WebWidget down to… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2010, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 836 matching lines...) Expand 10 before | Expand all | Expand 10 after
847 return; 847 return;
848 848
849 if (ScrollbarThemeMacCommon::isOverlayAPIAvailable()) { 849 if (ScrollbarThemeMacCommon::isOverlayAPIAvailable()) {
850 if (!supportsUIStateTransitionProgress()) 850 if (!supportsUIStateTransitionProgress())
851 return; 851 return;
852 if (ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar)) 852 if (ScrollbarPainter painter = scrollbarPainterForScrollbar(scrollbar))
853 [painter mouseExitedScroller]; 853 [painter mouseExitedScroller];
854 } 854 }
855 } 855 }
856 856
857 void ScrollAnimatorMac::willStartLiveResize()
858 {
859 if (!scrollableArea()->scrollbarsCanBeActive())
860 return;
861 if (ScrollbarThemeMacCommon::isOverlayAPIAvailable())
862 [m_scrollbarPainterController.get() startLiveResize];
863 }
864
865 void ScrollAnimatorMac::contentsResized() const 857 void ScrollAnimatorMac::contentsResized() const
866 { 858 {
867 if (!scrollableArea()->scrollbarsCanBeActive()) 859 if (!scrollableArea()->scrollbarsCanBeActive())
868 return; 860 return;
869 if (ScrollbarThemeMacCommon::isOverlayAPIAvailable()) 861 if (ScrollbarThemeMacCommon::isOverlayAPIAvailable())
870 [m_scrollbarPainterController.get() contentAreaDidResize]; 862 [m_scrollbarPainterController.get() contentAreaDidResize];
871 } 863 }
872 864
873 void ScrollAnimatorMac::willEndLiveResize()
874 {
875 if (!scrollableArea()->scrollbarsCanBeActive())
876 return;
877 if (ScrollbarThemeMacCommon::isOverlayAPIAvailable())
878 [m_scrollbarPainterController.get() endLiveResize];
879 }
880
881 void ScrollAnimatorMac::contentAreaDidShow() const 865 void ScrollAnimatorMac::contentAreaDidShow() const
882 { 866 {
883 if (!scrollableArea()->scrollbarsCanBeActive()) 867 if (!scrollableArea()->scrollbarsCanBeActive())
884 return; 868 return;
885 if (ScrollbarThemeMacCommon::isOverlayAPIAvailable()) 869 if (ScrollbarThemeMacCommon::isOverlayAPIAvailable())
886 [m_scrollbarPainterController.get() windowOrderedIn]; 870 [m_scrollbarPainterController.get() windowOrderedIn];
887 } 871 }
888 872
889 void ScrollAnimatorMac::contentAreaDidHide() const 873 void ScrollAnimatorMac::contentAreaDidHide() const
890 { 874 {
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
1181 return; 1165 return;
1182 1166
1183 m_visibleScrollerThumbRect = rectInViewCoordinates; 1167 m_visibleScrollerThumbRect = rectInViewCoordinates;
1184 } 1168 }
1185 1169
1186 bool ScrollAnimatorMac::canUseCoordinatedScrollbar() { 1170 bool ScrollAnimatorMac::canUseCoordinatedScrollbar() {
1187 return ScrollbarThemeMacCommon::isOverlayAPIAvailable(); 1171 return ScrollbarThemeMacCommon::isOverlayAPIAvailable();
1188 } 1172 }
1189 1173
1190 } // namespace blink 1174 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698