Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1749363002: Fix MSVC 2015 compiler complaint (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix MSVC 2015 compiler complaint This is/was slowly, but surely, driving me insane: DM.cpp(150): warning C4838: conversion from 'DWORD' to 'int' requires a narrowing conversion GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749363002 Committed: https://skia.googlesource.com/skia/+/75467865f5962d2d1e1378ff66e92d46e6015139

Patch Set 1 #

Patch Set 2 : Fix MSVC 2015 compiler issue in DM #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
robertphillips
4 years, 9 months ago (2016-03-01 20:39:52 UTC) #5
egdaniel
lgtm
4 years, 9 months ago (2016-03-01 20:44:50 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749363002/20001
4 years, 9 months ago (2016-03-01 20:50:30 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 21:03:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749363002/20001
4 years, 9 months ago (2016-03-01 22:09:30 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 22:10:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/75467865f5962d2d1e1378ff66e92d46e6015139

Powered by Google App Engine
This is Rietveld 408576698