Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1749353004: Ship ES2015 Function.name reform (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship ES2015 Function.name reform BUG=v8:3699, chromium:588803 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/edeaab7da0afaebca3461d19bfcf3b2b7cb51528 Cr-Commit-Position: refs/heads/master@{#34474}

Patch Set 1 #

Patch Set 2 : Should now pass all tests #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 4 chunks +6 lines, -3 lines 0 comments Download
M test/mjsunit/debug-backtrace.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-stepin-accessor.js View 1 7 chunks +13 lines, -13 lines 0 comments Download
M test/mjsunit/es6/classes.js View 1 2 chunks +3 lines, -5 lines 0 comments Download
M test/mjsunit/object-literal.js View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
adamk
4 years, 9 months ago (2016-03-01 20:44:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749353004/1
4 years, 9 months ago (2016-03-01 20:44:46 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/14510)
4 years, 9 months ago (2016-03-01 20:59:46 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749353004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749353004/20001
4 years, 9 months ago (2016-03-03 01:30:41 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/190747)
4 years, 9 months ago (2016-03-03 02:59:59 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749353004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749353004/40001
4 years, 9 months ago (2016-03-03 20:23:05 UTC) #12
adamk
+yangguo in case you want to see the complete thing This is now ready to ...
4 years, 9 months ago (2016-03-03 20:23:30 UTC) #14
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-03 22:34:07 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/191143)
4 years, 9 months ago (2016-03-03 23:15:44 UTC) #17
adamk
On 2016/03/03 23:15:44, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 9 months ago (2016-03-03 23:20:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749353004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749353004/40001
4 years, 9 months ago (2016-03-04 02:18:56 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-04 04:03:31 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 04:04:23 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/edeaab7da0afaebca3461d19bfcf3b2b7cb51528
Cr-Commit-Position: refs/heads/master@{#34474}

Powered by Google App Engine
This is Rietveld 408576698