Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1913)

Unified Diff: third_party/WebKit/public/web/WebInputEvent.h

Issue 1749343004: Implement Wheel Gesture Scrolling on OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebInputEvent.h
diff --git a/third_party/WebKit/public/web/WebInputEvent.h b/third_party/WebKit/public/web/WebInputEvent.h
index 3be5b18ebb24d3d90a822ec613be11e02767e113..ad6d1c6c4b639ae5b395e40bfdea57da66dadcf6 100644
--- a/third_party/WebKit/public/web/WebInputEvent.h
+++ b/third_party/WebKit/public/web/WebInputEvent.h
@@ -513,6 +513,16 @@ public:
// If true, this event will skip hit testing to find a scroll
// target and instead just scroll the viewport.
bool targetViewport;
+ // If true, this event comes after a non-inertial gesture
+ // scroll sequence; OSX has unique phases for normal and
+ // momentum scroll events. Should always be false for touch based
+ // input as it generates GestureFlingStart instead.
+ bool inertial;
+ // True if the begin was generated when phase information is available
+ // for touchpad and for every scroll update we are generating a GSB/GSU/GSE
+ // tuple. This is a temporary variable that forces the non-latching behavior
+ // until crbug.com/526463 is fully implemented.
tdresser 2016/03/08 14:28:53 Mentioning that these synthesized begin events are
dtapuska 2016/03/08 20:31:49 Done.
+ bool synthetic;
} scrollBegin;
struct {
@@ -536,6 +546,16 @@ public:
// The original delta units the scrollBegin and scrollUpdates
// were sent as.
ScrollUnits deltaUnits;
+ // If true, this event comes after a non-inertial gesture
+ // scroll sequence; OSX has unique phases for normal and
tdresser 2016/03/08 14:28:53 Is this correct? If this is true, the event comes
dtapuska 2016/03/08 20:31:49 correct; I had copied the text from the begin whic
+ // momentum scroll events. Should always be false for touch based
+ // input as it generates GestureFlingStart instead.
+ bool inertial;
+ // True if the begin was generated when phase information is available
+ // for touchpad and for every scroll update we are generating a GSB/GSU/GSE
+ // tuple. This is a temporary variable that forces the non-latching behavior
+ // until crbug.com/526463 is fully implemented.
tdresser 2016/03/08 14:28:53 I'd mention that these are only needed to match wi
dtapuska 2016/03/08 20:31:49 Done.
+ bool synthetic;
} scrollEnd;
struct {

Powered by Google App Engine
This is Rietveld 408576698