Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1749343002: Revert of [wasm] Add support for 64-bit LEB encodings. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
Reviewers:
titzer, ahaas, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Add support for 64-bit LEB encodings. (patchset #6 id:100001 of https://codereview.chromium.org/1746063003/ ) Reason for revert: [Sheriff] Seems to break chromium win compile: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/3800/steps/compile/logs/stdio Original issue's description: > [wasm] Add support for 64-bit LEB encodings. > > R=binji@chromium.org,ahaas@chromium.org > BUG= > > Committed: https://crrev.com/616f05496e9867cfa934098a76826cfde7feeaa2 > Cr-Commit-Position: refs/heads/master@{#34406} TBR=ahaas@chromium.org,binji@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/0fbc4f445958863eb21cff66a2612860baeb4f95 Cr-Commit-Position: refs/heads/master@{#34407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -279 lines) Patch
M src/wasm/decoder.h View 2 chunks +33 lines, -64 lines 0 comments Download
M test/unittests/wasm/decoder-unittest.cc View 2 chunks +0 lines, -215 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [wasm] Add support for 64-bit LEB encodings.
4 years, 9 months ago (2016-03-01 19:55:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749343002/1
4 years, 9 months ago (2016-03-01 19:55:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 19:55:20 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 19:56:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fbc4f445958863eb21cff66a2612860baeb4f95
Cr-Commit-Position: refs/heads/master@{#34407}

Powered by Google App Engine
This is Rietveld 408576698