Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1749333004: Fill the new index in Analysis Server. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +8 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index2/index2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/services/index2/index2_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-02 21:45:01 UTC) #1
Brian Wilkerson
LGTM, although I'm surprised by the number of places we create an analysis server.
4 years, 9 months ago (2016-03-02 21:57:28 UTC) #2
scheglov
4 years, 9 months ago (2016-03-02 22:00:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9e82c7e67cf8de0997bad52b641330055d1f4a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698