Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1749233002: Convert float64 to float32 when coerced with a heapf32 assignment. (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Convert float64 to float32 when coerced with a heapf32 assignment. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/2a9a770c2a1bde809c18f749a19b6a5f75f0ce5c Cr-Commit-Position: refs/heads/master@{#34404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/wasm/asm-wasm-builder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bradnelson
4 years, 9 months ago (2016-03-01 17:39:53 UTC) #1
titzer
lgtm
4 years, 9 months ago (2016-03-01 17:55:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749233002/1
4 years, 9 months ago (2016-03-01 18:04:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 18:06:30 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2a9a770c2a1bde809c18f749a19b6a5f75f0ce5c Cr-Commit-Position: refs/heads/master@{#34404}
4 years, 9 months ago (2016-03-01 18:07:33 UTC) #7
bradn
4 years, 9 months ago (2016-03-01 18:39:31 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698