Issue 1749213006: use Source.isInSystemLibrary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1749213006: use Source.isInSystemLibrary (Closed)

Created:
4 years, 9 months ago by Jennifer Messerly

Modified:
4 years, 9 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

use Source.isInSystemLibrary Just a small cleanup to use the property instead of comparing the URI R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/21a8c695c6059028aa76ed8fddacd5c3b27c301d

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
M	lib/src/codegen/js_module_item_order.dart	View	1	3 chunks	+4 lines, -9 lines	0 comments	Download
M	lib/src/compiler.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/src/server/server.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/transformer_e2e_test.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

4 years, 9 months ago (2016-03-02 21:07:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
21a8c695c6059028aa76ed8fddacd5c3b27c301d (presubmit successful).