Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1749213005: Revert of Make the EarlyInitStartup Code Default (Closed)

Created:
4 years, 9 months ago by robliao
Modified:
4 years, 9 months ago
CC:
chromium-reviews, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make the EarlyInitStartup Code Default (patchset #1 id:1 of https://codereview.chromium.org/1453923002/ ) Reason for revert: Reverting - Looks like we can't easily get perf data from the bots. Original issue's description: > Make the EarlyInitStartup Code Default > > We're satisfied with the performance characteristics of running Extension > Feature Initialization on a background thread that we'd like to do it > all the time now. > > BUG=470743 > > Committed: https://crrev.com/697fb4718088e9b87a30f21f57168af70ef273ae > Cr-Commit-Position: refs/heads/master@{#360352} > > Committed: https://crrev.com/9b13cbdc3205421a28bd583878c1108ed0eaead0 > Cr-Commit-Position: refs/heads/master@{#378308} TBR=jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=470743 Committed: https://crrev.com/088106bebeac47281eb94ec5af24f5205b4819a1 Cr-Commit-Position: refs/heads/master@{#378782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
robliao
Created Revert of Make the EarlyInitStartup Code Default
4 years, 9 months ago (2016-03-02 17:56:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749213005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749213005/1
4 years, 9 months ago (2016-03-02 17:56:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749213005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749213005/1
4 years, 9 months ago (2016-03-02 18:02:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749213005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749213005/1
4 years, 9 months ago (2016-03-02 18:31:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 18:41:51 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 18:42:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/088106bebeac47281eb94ec5af24f5205b4819a1
Cr-Commit-Position: refs/heads/master@{#378782}

Powered by Google App Engine
This is Rietveld 408576698