Add a Syzygy fetch config.

Add a Syzygy fetch config.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299057

[Sébastien Marchand, 2016-03-02 17:07:21]

sebmarchand@chromium.org changed reviewers:
+ maruel@chromium.org

[Sébastien Marchand, 2016-03-02 17:07:21]

PTAL.

[M-A Ruel, 2016-03-02 17:29:28]

On 2016/03/02 17:07:21, Sébastien Marchand wrote:
> PTAL.

wouldn't that make the CI depend on github?

[Dirk Pranke, 2016-03-02 17:35:59]

On 2016/03/02 17:29:28, M-A Ruel wrote:
> On 2016/03/02 17:07:21, Sébastien Marchand wrote:
> > PTAL.
> 
> wouldn't that make the CI depend on github?

The CI doesn't use fetch .

You want to use github here, because that's the repo that you actually commit
to.

There's a precedent in the fetch_config for mojo, for example.

I'm a bit surprised that you're using DEPS.syzygy, rather than just DEPS,
though?

[Sébastien Marchand, 2016-03-02 17:36:05]

I don't know :) , the dartium config is already depending on GitHub
(https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/fetc...),
not saying that this is a good thing, but I'm not sure if it's a bad one too.
(also, why would the CI use this config ?)

We have a chromium.googlesource clone of this project:
https://chromium.googlesource.com/external/github.com/google/syzygy/ but I don't
know if it can be used for development (i.e. it's a clone of the Syzygy repo, I
don't know if you can commit in it).

[Sébastien Marchand, 2016-03-02 17:39:06]

Yeah, we're using DEPS.syzygy for historical reasons (this repo was also
containing the Sawbuck project). We could switch back to DEPS but it'll break
the setup of most of the developers (not a big deal, but not sure that it's
worth it?)

[Dirk Pranke, 2016-03-02 18:21:08]

On 2016/03/02 17:39:06, Sébastien Marchand wrote:
> Yeah, we're using DEPS.syzygy for historical reasons (this repo was also
> containing the Sawbuck project). We could switch back to DEPS but it'll break
> the setup of most of the developers (not a big deal, but not sure that it's
> worth it?)

Why would that break the setup of most developers? Can't you just rename the
file?

[Dirk Pranke, 2016-03-02 18:21:46]

On 2016/03/02 18:21:08, Dirk Pranke wrote:
> On 2016/03/02 17:39:06, Sébastien Marchand wrote:
> > Yeah, we're using DEPS.syzygy for historical reasons (this repo was also
> > containing the Sawbuck project). We could switch back to DEPS but it'll
break
> > the setup of most of the developers (not a big deal, but not sure that it's
> > worth it?)
> 
> Why would that break the setup of most developers? Can't you just rename the
> file?

i.e., I think gclient will default back to looking for 'DEPS' if it doesn't find
'DEPS.syzygy',
but I could be wrong ...

[Sébastien Marchand, 2016-03-02 18:27:54]

Ha ok, I didn't knew that. I'll move my DEPS file then.

[Dirk Pranke, 2016-03-02 18:52:18]

On 2016/03/02 18:27:54, Sébastien Marchand wrote:
> Ha ok, I didn't knew that. I'll move my DEPS file then.

I could well be wrong, we should probably check first to see :).

[Sébastien Marchand, 2016-03-02 19:31:12]

Looks like you're right ! I've renamed our DEPS file, updated our builders
etc... PTAnL.

[Dirk Pranke, 2016-03-02 19:55:14]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-02 19:55:15]

lgtm

[Sébastien Marchand, 2016-03-02 19:55:46]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-03-02 19:55:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749213002/20001

[commit-bot: I haz the power, 2016-03-02 19:58:27]

Description was changed from

==========
Add a Syzygy fetch config.
==========

to

==========
Add a Syzygy fetch config.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299057
==========

[commit-bot: I haz the power, 2016-03-02 19:58:27]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299057