Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: net/spdy/spdy_framer_test.cc

Issue 1749203002: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed implementations, No functional … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115342288
Patch Set: Revert to Patch Set 1 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_framer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_framer.h" 5 #include "net/spdy/spdy_framer.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 bool fin) override { 90 bool fin) override {
91 LOG(FATAL) << "Unexpected data frame header"; 91 LOG(FATAL) << "Unexpected data frame header";
92 } 92 }
93 void OnStreamFrameData(SpdyStreamId stream_id, 93 void OnStreamFrameData(SpdyStreamId stream_id,
94 const char* data, 94 const char* data,
95 size_t len, 95 size_t len,
96 bool fin) override { 96 bool fin) override {
97 LOG(FATAL); 97 LOG(FATAL);
98 } 98 }
99 99
100 void OnStreamEnd(SpdyStreamId stream_id) override { LOG(FATAL); }
101
100 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override { 102 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {
101 LOG(FATAL); 103 LOG(FATAL);
102 } 104 }
103 105
104 SpdyHeadersHandlerInterface* OnHeaderFrameStart( 106 SpdyHeadersHandlerInterface* OnHeaderFrameStart(
105 SpdyStreamId stream_id) override { 107 SpdyStreamId stream_id) override {
106 LOG(FATAL); 108 LOG(FATAL);
107 return nullptr; 109 return nullptr;
108 } 110 }
109 111
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 LOG(INFO) << "OnStreamFrameData(" << stream_id << ", \""; 320 LOG(INFO) << "OnStreamFrameData(" << stream_id << ", \"";
319 if (len > 0) { 321 if (len > 0) {
320 for (size_t i = 0 ; i < len; ++i) { 322 for (size_t i = 0 ; i < len; ++i) {
321 LOG(INFO) << std::hex << (0xFF & static_cast<unsigned int>(data[i])) 323 LOG(INFO) << std::hex << (0xFF & static_cast<unsigned int>(data[i]))
322 << std::dec; 324 << std::dec;
323 } 325 }
324 } 326 }
325 LOG(INFO) << "\", " << len << ")\n"; 327 LOG(INFO) << "\", " << len << ")\n";
326 } 328 }
327 329
330 void OnStreamEnd(SpdyStreamId stream_id) override {
331 LOG(DFATAL) << "Unimplemented.";
332 }
333
328 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override { 334 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {
329 EXPECT_EQ(header_stream_id_, stream_id); 335 EXPECT_EQ(header_stream_id_, stream_id);
330 data_bytes_ += len; 336 data_bytes_ += len;
331 LOG(INFO) << "OnStreamPadding(" << stream_id << ", " << len << ")\n"; 337 LOG(INFO) << "OnStreamPadding(" << stream_id << ", " << len << ")\n";
332 } 338 }
333 339
334 SpdyHeadersHandlerInterface* OnHeaderFrameStart( 340 SpdyHeadersHandlerInterface* OnHeaderFrameStart(
335 SpdyStreamId stream_id) override { 341 SpdyStreamId stream_id) override {
336 LOG(FATAL); 342 LOG(FATAL);
337 return nullptr; 343 return nullptr;
(...skipping 5208 matching lines...) Expand 10 before | Expand all | Expand 10 after
5546 5552
5547 EXPECT_EQ(1, visitor->data_frame_count_); 5553 EXPECT_EQ(1, visitor->data_frame_count_);
5548 EXPECT_EQ(strlen(four_score), static_cast<unsigned>(visitor->data_bytes_)); 5554 EXPECT_EQ(strlen(four_score), static_cast<unsigned>(visitor->data_bytes_));
5549 EXPECT_EQ(0, visitor->headers_frame_count_); 5555 EXPECT_EQ(0, visitor->headers_frame_count_);
5550 } 5556 }
5551 } 5557 }
5552 5558
5553 } // namespace test 5559 } // namespace test
5554 5560
5555 } // namespace net 5561 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_framer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698