Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1749203002: Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed implementations, No functional … (Closed)

Created:
4 years, 9 months ago by danzh1
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dahollings, Bence
Base URL:
https://chromium.googlesource.com/chromium/src.git@115342288
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added new method OnStreamEnd to SpdyFramerVisitorInterface, stubbed implementations, No functional change. As suggested by birenroy@ in b/27248264: Added a new visitor interface method to the SpdyFramerVisitorInterface with signature: virtual void OnStreamEnd(SpdyStreamId stream_id) = 0; Stubbed the new method in all implementors. The eventual goal is to use the new method to handle stream ends consistently, removing the need for fin boolean arguments in the other methods in the visitor. Merge internal change: 115370186 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : git pull and rebase from 115342288 #

Patch Set 3 : Revert to Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M net/quic/quic_headers_stream.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
danzh1
4 years, 9 months ago (2016-03-01 16:44:29 UTC) #1
Ryan Hamilton
4 years, 9 months ago (2016-03-01 18:13:21 UTC) #2
lgtm

bnc: FYI, this change includes spdy changes

Powered by Google App Engine
This is Rietveld 408576698