Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1749163002: Wire up stack traces again (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@trivialcleanup
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove debug print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M include/private/GrAuditTrail.h View 4 chunks +9 lines, -3 lines 0 comments Download
M src/gpu/GrAuditTrail.cpp View 1 2 chunks +14 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
joshualitt
I'm just throwing this out there, I'm not saying this is the best way to ...
4 years, 9 months ago (2016-03-01 15:48:55 UTC) #3
jcgregorio
On 2016/03/01 at 15:48:55, joshualitt wrote: > I'm just throwing this out there, I'm not ...
4 years, 9 months ago (2016-03-01 16:08:59 UTC) #4
joshualitt
On 2016/03/01 16:08:59, jcgregorio wrote: > On 2016/03/01 at 15:48:55, joshualitt wrote: > > I'm ...
4 years, 9 months ago (2016-03-01 17:52:55 UTC) #5
joshualitt
On 2016/03/01 17:52:55, joshualitt wrote: > On 2016/03/01 16:08:59, jcgregorio wrote: > > On 2016/03/01 ...
4 years, 9 months ago (2016-03-02 14:33:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749163002/20001
4 years, 9 months ago (2016-03-02 14:33:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/f55c3644850409c9410051c7a7f18af8d65bf990
4 years, 9 months ago (2016-03-02 16:11:40 UTC) #10
ethannicholas
4 years, 9 months ago (2016-03-02 16:12:49 UTC) #11
Message was sent while issue was closed.
On 2016/03/02 16:11:40, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/f55c3644850409c9410051c7a7f18af8d65bf990

belated lgtm

Powered by Google App Engine
This is Rietveld 408576698